Editor image/file upload selector: wrong tips

When I Add an image or a file via the icon, the remote_tip_with_attachments (client.yml) is also shown for the from_my_computer field (instead of the local_tip_with_attachments):

This is because both reference {{tip}} rather than the specific translation keys:

https://github.com/discourse/discourse/blob/be3a5a56ccc284b352aa65080fc6b955f73cc72a/app/assets/javascripts/discourse/templates/modal/upload-selector.hbs#L5-L20

2 Likes

Sure @zogstrip can you have a look?

Sorry, I had a fix already :blush:

https://github.com/discourse/discourse/pull/4357

5 Likes