Embedding google maps short urls is broken


#1

Just see the results (short URL: Google Maps, long URL: Google Maps).

edit: The large map also does not show the location.


Disable map scroll by default?
(Kane York) #2

You need to choose the embed link, I think:

The “share” link doesn’t have enough data.


(Jens Maier) #3

Just copy & paste the address from your browser’s address bar, no need to get a special link:

https://www.google.com/maps/place/New+York+City,+New+York,+USA/@40.6991485,-73.9989071,9z/data=!4m2!3m1!1s0x89c24fa5d33f083b:0xc80b8f06e177fe62?hl=de

https://www.google.com/maps/@40.6964248,-74.0590794,12z?hl=de

For google.de:
https://www.google.de/maps/@52.5153877,13.3792687,15z


(Jeff Atwood) #4

Yes, but you could argue that onebox should know how to expand short URLs. This is not a bug, though, but a feature request.


(Jens Maier) #5

Actually, this is a bug. Short links are supposed to be resolved, but it doesn’t work for HTTPS.

I just can’t figure out why the shortened link in question resolves to a world map when embedded. It doesn’t make sense… from short → long → canonical:

  1. https://goo.gl/maps/EOjie
  2. https://www.google.de/maps/place/New+York+City,+New+York,+USA/@40.7033127,-73.979681,11z/data=!3m1!4b1!4m2!3m1!1s0x89c24fa5d33f083b:0xc80b8f06e177fe62
  3. https://maps.google.de/maps?sll=40.7033127,-73.979681&sspn=0.3998584,0.7033743&cid=14414772292044717666&q=New+York+City,+New+York,+USA&dg=ntvb

All of these come straight from Google, the only alteration is that the third link has output=classic removed from its query parameters. It still works tho: paste any link into the address bar and it just works.


(Jens Maier) #6

This should fix it:

https://github.com/discourse/onebox/pull/280

I’ve also added support for preview images… at least I hope. I’m not certain if this kind of static map does actually require a Google API key.


(Kane York) #7

Note: We have the iframe refreshing bug here, we need to implement a ‘preview’ onebox method.


(Jens Maier) #9

… you were saying? :grin:


(Kane York) #10

Uhh… drafts? Delayed pressing of Reply! (that’s the ticket)


(Jens Maier) #11

Sorry, I probably shouldn’t engage in witty banter past 5am. Can I get that ninja-delete feature already? :wink:

Anyway, the PR above does include support for static preview images for the composer.


(Arpit Jalan) #12