Embedding: "username for topic creation" is not required


(Michael - DiscourseHosting.com) #1

The “username for topic creation” is currently not a required field in the embedding settings.
However, without that value, embedding will not work.

There is a check for valid username on that input field, it should be checking for not-empty as well ?


(Jeff Atwood) #2

Good point, @eviltrout can you have a look?


(Robin Ward) #3

Nice find. Fixed here:

https://github.com/discourse/discourse/commit/780275730698b74671096bc52709dffa648c9941


(Jeff Atwood) #4