Allowing edit is possibly a spam vector if implemented incorrectly (cause people could edit it JUST as you are approving a previous version) however if we were careful you could very cleanly allow safe edits. Which enormously improves the end user experience.
The situation for posting in a topic is even worse.
I can not tell it exists in my profile, I can not tell it is out there for approval on the topic. I can not edit it.
As an end user, when I experienced this whole thing at https://discuss.reactjs.org/ I felt absolutely terrible. It is like you are driving completely blind.
@xrav3nz as you are improving the moderation queue I really want you to keep this in mind, making a user hostile feature even more easy for moderators may not be the correct order of operation here. We got to think about the users.
Akismet and moderation queue really need to be unified, having 2 systems now that have radically different features is really bad. Akismet is now missing all the fancy edit stuff @xrav3nz just added.
Thanks for pointing this out! As I was testing the approval workflow for my last PR, I did feel awkward about the end-user experience. Chose to ignore that at the moment because that wasn’t the area of focus. Now is probably a good time to come back to this!
A few potential improvements off the top of my head:
User Activity Page:
include pending posts into all/topics/replies, with indication that they’re awaiting approval
a separate section dedicated to pending posts; only visible if the user has pending posts
“Post Needs Approval” Dialog
link to the “pending posts” section on User Activity Page
“3 staff who are online have been notified”? - This can also be a bad idea
Topic list / post stream
could display the pending topic/reply with clear indication that it’s invisible and awaiting approval
the pending posts’ ordering with respect to other posts is important
Approval queue edit:
mandatory edit reason if the body of the post had been edited (or some other threshold)
Additionally, what about a system generated PM similar to the one we have for Akismet? This is to empathize with the user, and it is only sent the first time that a user submitted a post pending approval.
Allowing user edits to posts in the queue would be very valuable for us. I anticipate that members of our community will post topics without reading the pinned topic we have. Providing a list of a few things to make sure their post includes in the ‘Post needs Approval’ dialogue would reduce the amount of back-and-forth between our moderators and the topic creator.
I can not tell in which topics I have pending approval posts
I can not edit my pending approval posts
I can not tell when my thing is going to be approved
What I would like:
On topics, simply display my unapproved post as the last post in the stream with special formatting saying it is pending approval. It will always be last no matter what. This is editable by me.
When I post instead of “Please be patient”, “It usually takes about 4 hours for posts to be approved”, we can recalculate weekly.
Extra super bonus points stretch goal, allow 2 TL3s to approve one of these guys so it happens faster
@eviltrout maybe we can assign this out once your review queue is shipped? It would be a nice little first project for someone who is not yet familiar with the review queue.
“Excluir” pelo usuário final não requer confirmação. 1 clique e ele é excluído para sempre sem possibilidade de desfazer.
Nenhuma maneira de “editar” uma vez na fila de revisão, você deve excluir e reenviar.
Postagens “Aguardando aprovação” não exibem o contexto completo (a que estão respondendo).
Não o vinculamos ao local onde você pode ver todas as postagens pendentes: (não é um hyperlink para a atividade)
A área de administração vincula ao “post principal” do tópico, não ao que você acabou de responder, ou ao final do tópico.
Eu diria que fizemos muito progresso desde que levantei isso pela primeira vez, no entanto, não gostaria de fechar isso antes de:
Adicionar uma confirmação OU opção de desfazer para exclusão
Vincular “2 posts pendentes” à atividade do usuário, para que você possa encontrá-los facilmente.
Mostrar a que algo está respondendo na trilha de auditoria
Melhorar os links para que levem você ao post, não à primeira coisa do tópico.
Editar é uma meta ambiciosa, é um pouco complicado porque existem condições de corrida.
Acho que precisamos decidir o quanto queremos aprimorar o recurso, sinto que deveríamos dar mais uma semana de tempo de desenvolvimento e depois fechar isso, fazer todas as melhorias fáceis e claras.
Também, da perspectiva de um administrador, sempre acho muito difícil decidir o que fazer com um post que precisa de aprovação, pois falta contexto na fila de aprovação.
Especificamente, vi bots de spam copiando e colando uma resposta e mudando uma ou duas palavras e postando novamente. Parece razoável sem contexto, mas assim que você visita o tópico e obtém o contexto, pode ver o que eles acabaram de fazer. Acho que pode fazer sentido adicionar suporte para aprovação diretamente do tópico, dessa forma você pode aprovar um post no local onde as pessoas responderam se você buscar um pouco mais de contexto. Isso, no entanto, claramente pode esperar.
just scope how this should work for now.
