Error message cannot be dismissed by keyboard

keyboard

(TechnoBear) #1

We’ve recently experienced a huge number of 502 errors (not a Discourse issue). The error message pop-up cannot be dismissed by keyboard.

Other pop-ups can be dismissed with Enter and I would expect this to be the same.


(Jeff Atwood) #2

Any idea why this dialog would be behaving differently @eviltrout?


(Sam Saffron) #3

I thought Robin isolated this to be an issue with an extension you have, @santouras ?


(cpradio) #4

That prevents closing the 502 error dialog box? The 502 error was likely due to a customization, but closing the dialog box should be core right?


(Sam Saffron) #5

Yeah, sorry I misunderstood…


(Mittineague) #6

Even the edit history modal?


(TechnoBear) #7

Actually, no - that uses Esc.


(Robin Ward) #8

Here’s a fix:

https://github.com/discourse/discourse/commit/952b3458834811f4f55fa7249c6212ea23f6ed37


(Régis Hanol) #9