This is split out from the master accessibility thread: Accessibility audit and shepherd for making improvements - #16 by kevinrobinson
The issue here is that in certain tutorial popups, users aren’t able to get out of it with using a keyboard alone. Note that the initial report is from March 2017.
Report:
In the Banner, and in the Reply field (the pop-up that comes up to remind you of discussion etiquette), you cannot dismiss the banner nor make the warning go away without the use of a mouse. This must change as it is what we call a keyboard trap. There should be a way to give the dismiss X keyboard focus and actionability. This can be worked around by setting an option to disable this feature on an instance, but ideally the default setup upstream would included keyboard accessibility as well.
This may have changed since the original audit was done. It’s visually different than what I remember myself too, FWIW. Here’s an example of what I see opening this topic now:
For me on Chrome Desktop this works as expected, and there’s no issue on that popup.
Looking back in code to confirm that this was fixed, I found what I think is the code adding the “ESC” but blaming makes it look like this hasn’t been changed in the last six months: https://github.com/discourse/discourse/blame/a0b2b3c8a76adf1ef52f0c31424017b44d232221/app/assets/javascripts/discourse/controllers/composer.js.es6#L249
I’ve pinged folks on my end to help confirm that this is fully accessible, and so unless I hear back differently from there or other folks can chime in here I think we can consider this one resolved.
