Error with Cakeday on Stable - no sitesettings.navigation_menu

bug
,
1

image
image1387×1596 207 KB

Cakeday seems to be incompatible with the recently updated Discourse 2.8.14 and causes a white screen

 if (siteSettings.navigation_menu !== "legacy") {
      if (cakedayEnabled) {
        api.addCommunitySectionLink({
          name: "anniversaries",
          route: "cakeday.anniversaries.today",
          title: I18n.t("anniversaries.title"),
          text: I18n.t("anniversaries.title"),
        });
      }

      if (cakedayBirthdayEnabled) {
        api.addCommunitySectionLink({
          name: "birthdays",
          route: "cakeday.birthdays.today",
          title: I18n.t("birthdays.title"),
          text: I18n.t("birthdays.title"),
        });
      }
    } else {

The problem seems to be on line 158 of discourse-cakeday/assets/javascripts/discourse/initializers/cakeday.js, which does not take into account the fact that the stable branch has not yet added sitesettings.navigation_menu

2 Likes
2

Could you maybe add a .discourse-compatibility file, @tgxworld ?

1 Like
6

Looks like I accidentally broke the plugin’s compatibility with stable previously. I have a fix for it in

5 Likes
7

That fixed it for us — thanks!