Failed emoji unicode -> image conversion

bug
1

Continuing the discussion from Ratings instead of Hearts for Likes:

Why this didn’t become this:

?

4 Likes
2

0️⃣ hmm let’s see 1️⃣

Yeah that is odd, any thoughts @joffreyjaffeux

3 Likes
5

Turns out that’s an old decision from @eviltrout https://github.com/discourse/discourse/blob/master/app/models/emoji.rb#L137

Not sure about the reasons?

So :one: will work but :one: won’t get replaced.

5 Likes
6

I don’t remember the exact reason (this is why I am now bullish on more detailed commit messages) but I suspect that a lot of symbols were being converted that we didn’t want to. I wouldn’t mind removing it to see what happens. Maybe we can re-learn the reason :slight_smile:

6 Likes
7

That should fix it:

https://github.com/discourse/discourse/pull/7978

4 Likes