Feature request: link to title not body when sharing to discourse PWA

Feature
1

It would be really nice if links shared to the Title instead of (just) the Post body so that the Title was populated automatically just like it does if you do that within a site.

Is there any reason why the Post body is the target?

1 Like
2

Would you accept a PR here or is there a reason why it was done this way?

@Falco what PR introduced this feature (I had a look but couldnā€™t track it down)?

3

This been a loooooong time ago, but wonā€™t this break when you arenā€™t sharing a link but a textual content?

At least youā€™d had to detect if the sharing text is a link and send it to the proper field.

1 Like
4

Yeah, thatā€™s presumably more challenging because arenā€™t you just GETing a URL e.g. https://blah.com/new-topic? ...

But happy to take a look

1 Like
5

If most sites are sending just a URL nowadays Iā€™d be happy with the change.

1 Like
6

Iā€™ve found the code :detective: and Iā€™ll take a look if we can handle both ā€¦ but agree URLā€™s are probably sent 99% of the time, so worth considering ā€¦

1 Like
7

OK Iā€™ve worked out how to support both:

  • text shares will go to body
  • titles go to title
  • link shares will go to title (and then render as a fully expanded title and in the body a nice onebox upon instantiation with all that comes with that including topic list previews)

Currently the update is in a working plugin:

Iā€™ll submit this as a PR as really a no brainer.

Tested this on both Android and Windows (Edge) PWAs and seems to work great.

1 Like
8

PR is here: