Feedback on new 🍔 and user menus

[riking (Kane York)]

Looks like we can use vh if you can get it to work!

http://caniuse.com/#search=vh

[cpradio]

Looks like iOS 7 would be your biggest worry (based on the footnotes).

[eviltrout (Robin Ward)]

@awesomerobot

learned about vh literally yesterday at an event apart

Maybe, but I’ve got a lot of Javascript right now calculating all the various heights. I’d probably have to remove all that if we used vh.

In the meantime I’ve fixed the scrollbar bug.

[awesomerobot (Kris)]

that’s true! I can look into it more this weekend and we might be able to get rid of some of that js

[cpradio]

@eviltrout

@awesomerobot

learned about vh literally yesterday at an event apart

Maybe, but I’ve got a lot of Javascript right now calculating all the various heights. I’d probably have to remove all that if we used vh.

In the meantime I’ve fixed the scrollbar bug.

I can still reproduce both images in Chrome from

Feedback on new and user menus

Not sure who should be looking at this, but yep, smaller screen sizes where the notifications may be long make it impossible to scroll to the bottom of the menu [image] When the window size is exapnded a bit, the menu scrollbar disappears even though the entire menu isn’t shown. [image]

But maybe that wasn’t what you were solving?

[sam (Sam Saffron)]

The positioning on iPhone is still a bit shonky

Able to repro:

And cut off words on scroll

[Mittineague]

Firefox latest.

Very odd. It’s like the menu scrollbar gets “pushed up” when the viewport narrows.

[Stephen]

It isn’t just mobile safari, observed on Chrome today:

scrolls to this, top bar seems to have totally detached:

And sometimes it stays in place, but slides up a row. Before:

After:

[danwad (Daniel)]

The category list isn’t handling wrapping very nicely on our Discourse. We have a few longer category names than here on meta and the new posts count wraps on to the next line when the ellipsis appears.

[TechnoBear]

Feedback on new and user menus

We can probably add direct keyboard shortcuts to go to messages. And certainly you should be able to go to your profile via keyboard shortcuts. Perhaps g, p to go to your profile g, m to go to your messages Also @eviltrout there is duplication in the keyboard shortcuts now since a top level glyph was eliminated.

Thanks for the profile and logout shortcuts - I really appreciate them.

Any progress on g, m for messages?

[eviltrout (Robin Ward)]

@TechnoBear

Any progress on g, m for messages?

Easy peasy!

https://github.com/discourse/discourse/commit/a76d1079b25c48f6d2048274cf1648bad6d7ea2c

[simon]

I’ve played around with this a bit. There are some ideas for how to simplify the horizontal positioning here:
https://github.com/discourse/discourse/pull/3705

Feel free to use them

[TechnoBear]

Thanks, @eviltrout. Now I’m a happy bear.

[wesochuck (Wes Osborn)]

Does anyone else think that the entire row for view older notifications… link should be clickable instead of just the phrase itself? All the other notification rows in that menu appear to be clickable.

Chrome 44 on Chrome OS

[eviltrout (Robin Ward)]

Yes!

https://github.com/discourse/discourse/commit/2d684899f78f375d4bf75051b7b454899e470dfb

[tobiaseigen]

same thing for the logout row? or do you not want to make it THAT easy to log out accidentally?

[tobiaseigen]

loving the new hamburger menu too - thanks for that!

shouldn’t the akismet link move up to the admin links? could use an A for the glyph.

[cpradio]

@tobiaseigen

loving the new hamburger menu too - thanks for that!

ditto. I didn’t even realize it had changed (that’s how often I use it). But it does look nice.

[Kuro (from TDWTF)]

While the grouping is nice, I have 2 complaints about this design.
Keep in mind that I am a simple user. As far as I can see, this is the same menu every user has who logs in . (No Admin/Mod/TL4-stuff)

red: The design looks unbalanced in these two places because of the grouping. I’d suggest either finding another link that can take fill the empty space (at least one - preferrably the top)

blue: I’d suggest that categories - while it may be a legit link - should be styled diferrently. It acts as a header of sorts for the categories below so special styling might be legit.

Filed Under: complaints are pretty much the same a suggestions, right?

[gerhard (Gerhard Schlager)]

Compared to the links in the hamburger, the links in the user profile are quite unnoticeable.

To make it consistent, shouldn’t the links in the profile menu be blue too?

Or at least the “Profile” link?

And can we get a larger click target for “Profile” please?