Fix deleted user email handling for staged users

Bug
1

It happened on my site too. I think the email doesn’t work when the post wasn’t added to the review queue because of a flag, but because it requires aporoval.

I first noticed when I was testing the Approve unless staged site setting and deleted the user when the post arrived and required approval. This was even more confusing as the user doesn’t really have an account. They only used email in.

I would be grateful if, in addition to the fix for non-flag reviewables such as post approval, a different handling method could also be found for staged users, who do not actually have an account.
(Similarly, I would still be grateful if the email were only sent once deletion was successful, if custom flag reasons worked, and if forums where the guidelines are not public did not refer to them in the email)

4 Likes
2

I am interested in understanding why this isn’t covered by the fix in the other topic. Doesn’t the fix for users that are deleted on posts that require approval also work for staged users that are deleted when thier posts require approval? Why isn’t needs_approval used in this case too?

3

The fix addresses part of the issue, but the second part relates to how we communicate that a staged user account has been deleted. For most staged users, the existence of an “account” is invisible, they only have one because they emailed in. Receiving an unexpected “your account has been deleted” email would likely be confusing. I think the messaging for this case needs to be handled differently. Everything else should behave the same as it does for a regular user.

1 Like