I’ve added the ability for users to enable the forcing of email context in their notifications and sent a pull request to Discourse, however it requires more discussion of the feature on meta, the reason for this post.
To answer @sam’s questions on the PR:
I am pretty uneasy with this change, its a very confusing setting to be adding to users.
Personal opinion - I don’t think it’s confusing. The option is labelled “Always include previous posts in notifications” which to me explains the purpose of the setting. Would some clarification text of what happens if the option is unchecked suffice?
also where do you stop? allow them to specify the amount of context? allow them to specify that context is included regardless of what was previously sent? allow them to specify if context goes before or after.
At the moment I just wanted to get the setting in there, but I’m not averse to extending it to a degree, like with the email digest. I could see this working as the same label, and if checked, a dropdown that offers some pre-defined settings (perhaps from 0 to the site configured context?). The site configured context option could then be reworded to imply a maximum amount of email context (which, to be honest, is what it already means currently).
As to where to stop, I don’t see a need to ‘stop’, that’s what software development is about, to me at least. We keep iterating over a feature to improve its use to users.
What are people’s thoughts and suggestions on this feature?
It’s my first time dabbling in Ruby, and first commit to the project, so I’d like to see it in there in some shape or form