The plugin is broken again. And seriously so. After the latest upgrade, I was no longer able to create posts or send emails and after hours of exploring various possible causes, it turns out that only uninstalling the plugin solved the problem (the plugin was deactivated all along, but that did not prevent it from breaking things).
Hum tested it on a live forum. I didn’t have any issue. I’ll try on my own version of the plugin on my forum tonight, and on another to confirm this. I’ll have a close look on the logs too
What plugins do you have ?
I’ll try with the same plugins to see if I can reproduce
This plugin must be broken if you use the Discourse bbcode (or other bbcode plugins) since I mostly use the same code for the markdown engine. I can make a specific branch if someone needs to use both.
If you can’t repro the brokenness, I’ll move it back. @tophee, you will need to provide better repro steps, but it seems this plugin works fine on latest.
Sorry, I forgot to reply. Not sure of it’s relevant anymore, but here we go:
These are the ones I have currently installed (and things are working fine):
History 0.1 Y
discourse-TL1-invites 0.0.2 Y
discourse-assign 0.1 N
Canned Replies 1.1 Y
discourse-data-explorer 0.2 Y
discourse-details 0.4 N
discourse-voting 0.4 Y Settings
discourse-narrative-bot 0.0.1 Y
discourse-nationalflags 1.0.0 N
discourse-nginx-performance-report 0.1 Y
discourse-ratings 0.2 Y
discourse-solved 0.1 Y
Spoiler Alert! 0.3 Y
staff-notes 0.0.2 Y
discourse-translator 0.2.0 Y
Watch Category 0.4 Y
docker_manager 0.1 Y
lazyYT 1.0.1 Y
poll 0.9 Y
Before that, I had these plus the formatting toolbar and it did not work. Removing the formatting toolbar fixed it. That’s all I can say. If it can’t be reproduced, could it be the interaction of two or more plugins that caused the problems? Or the problem was solved by something else (though I wouldn’t know what) that coincided with the removal of the plugin?
Version 3.0 available. Big change, and I’m sure you’ll like it : you can now select which button will appear on the toolbar. You don’t like the color button ? Deactivate it in the settings !
Also, this version allows us to add a RTL (right to left) support, you can deactivate the right alignment button and activate the left one.
You can’t (yet?) change the order of the buttons on the toolbar, it’s above my abilities
Please let me know if you have any issue during the upgrade or performance wise.
Now this is absolutely awesome! I was even proposing something of a sorts to the Team on discussion about composer and buttons in it, so I’m really happy to see it actually done by you!
Ha! I knew that I choose the best toolbar plugin
Good work!
With the latest option (we can choose which buttons can appear), I can add the size button, it’s a good idea, I’ll make an update very soon. It will be hidden by default I think.
For the color window, it’s above my capability to be honest. If someone can do something like this, I know there are a lot of people interested, I’ll gladly accept any pull request
It makes enormous amount of sense now to move this to a theme component, it makes adoption tons easier and there is nothing specific about the plugin that can not be done in a theme component.
That has a bunch of advantages cause even without your theme something sane will display, as opposed to ugle bbcode tags.
It also opens a general question which we should do elsewhere about how to get this formatting into emails, can you open one? Kind of open to having themes be allowed to add email.scss or something like that but there will be a lot of magic we need to add.
Would this limit the ability to use markdown/bbcodes inside the html divs with data-* attribute tags? I was just trying to do something like this on a discourse instance: <div data-floatr> ![image|283x72](upload://xD5khjH5UtWWvUnlvO5ZRA1aCw7.png)</div>
and it doesn’t seem to work. The following text
<div data-shadow>[u]hello world[/u]</div> ends up as:
[u]hello world[/u]
whereas bbcodes can be nested [b][u]hello world[/u][/b] >> hello world
Does this plugin interfere with Tiles Image Gallery and Slick Image Gallery at all? I can’t seem to get all three showing in the composer. If so, would moving it to a theme component allow the three to function together?
Yeah this is a bit tricky, but I guess the correct thing to do here if we want fancy bbcode is just to add a dependency on the official https://github.com/discourse/discourse-bbcode plugin. Or maybe have a theme setting for “bbcode” mode which requires the plugin vs “div” mode that requires no plugin.