Found unused variable `expires` at lib/secure_session.rb, it seem like a mistake

Sviluppatore
1

found unused variable expires at lib/secure_session.rb, it seem like a mistake

def set(key, val, expires: nil)
    expires ||= SecureSession.expiry
    $redis.setex(prefixed_key(key), SecureSession.expiry.to_i, val.to_s)
    true
  end
5 Mi Piace
2

@sam Should it be $redis.setex(prefixed_key(key), expires.to_i, val.to_s)? Looks like the specs don’t fail because they use the default value of 1 hour.

1 Mi Piace
3

Nice catch, yeah @gerhard that sounds right, fixed. Nice catch @coocooooo

2 Mi Piace