Gif functionality issues

AI-generated summary

BeefofAges reported two GIF functionality issues in Discourse: the GIF modal failing to display on mobile breakpoints and the search input not auto-focusing. Initially, Falco could not reproduce the mobile display issue but noted the focus problem occurred specifically in Chat. Moin provided video evidence confirming the issues on Meta. BeefofAges clarified that both bugs were isolated to the Chat interface, while the topic post interface worked correctly on all devices. Falco identified the root causes and implemented fixes via discourse/discourse#37384 and discourse/discourse-gifs#111. The autofocus issue was resolved in the theme, allowing immediate updates via the admin screen, while the Chat modal fix was part of the core code scheduled for deployment within hours. BeefofAges confirmed that after the deployment, all functionality was restored and working correctly.

I’ve discovered two issues with the gif functionality in Discourse.

The first, as discussed in the Discourse Gifs thread, involves the gif modal failing to display when in the mobile breakpoint. It happens across all browsers and device types including when a desktop browser is in mobile simulator mode. There are no errors in the console, the gif search model simply doesn’t display. All other breakpoints function normally.

The second issue is that the gif search modal no longer places focus on the search input element requiring an extra click to initiate typing the search term.

Happy to provide other details as needed.

1 Like

Can’t reproduce this I’m afraid.

Cool Squirtle Adjusts Sunglasses

Are you running the latest version of Discourse? Can you reproduce here on Meta?

I can’t reproduce this on topics neither. I see it happens on chat.

This is Meta

1 Like

So both issues are chat only?

1 Like

I think so. At least that’s where I noticed this, and the report in the component’s topics also reads like that to me:

The modal not displaying is on chat only; my apologies for not making that clear in the original post.

The input focus happens on desktop as well but, again, only in chat. The topic post gif interface is working correctly in my testing in both desktop and mobile breakpoints.

Couple of fixes

https://github.com/discourse/discourse/pull/37384

https://github.com/discourse/discourse-gifs/pull/111

5 Likes

Thanks! When should I expect the merged package(s) to be available? I saw an update to the gif component this morning but not sure if this was in it (and it still isn’t working on my Discourse instance).

1 Like

Autofocus issue is on the theme, so you can update it on your admin screen right now.

The “not shows in chat” was a issue on the chat side, which is part of our core, which will deploy to your site in a couple of hours.

3 Likes

Deployed to my instance, all is working well. Thanks again @Falco !

2 Likes

This topic was automatically closed after 41 hours. New replies are no longer allowed.