Help us test our new post rendering engine!

This branch is feeling stable enough to leave on meta permanently. So tonight will be the first night where I don’t roll it back overnight :slightly_smiling:

I’ve been updating the OP with the fixed bugs and those on my list. I’m also going to go through this topic now and delete the posts that have been solved just to keep it clean. Thanks for all the bug reports so far!

10 Likes

The speed difference is even more marked in even more marginal hardware. On an LG 39C

http://www.amazon.com/LG-Optimus-Dynamic-II-Tracfone/dp/B00HPX2NTG

I get:

  • 23 sec fresh load on try
  • 16 sec reload on try
  • 9 sec fresh load meta
  • 4-5 sec reload on meta

Both tests, topic of 22 posts, mostly text. On my home broadband. Times were just a mental count, but done several times. This is now making the topic page feel slow by comparison on that device…

12 Likes

My suggestion may be too extreme, but it is only an offer and I understand if it is not taken.

I use an LG 305C. Has a stock browser and Opera browser. If you want any perf tests from it, I am willing to do it.

I think we are focusing on “known” operating systems in order of market share, that is – Android, iOS, Windows Phone, perhaps Blackberry. It’s a steep dropoff after Android and iOS

Given the market share numbers, you can perhaps see why we felt compelled to spend almost two months of dev time rewriting everything in the topic page to make sure performance was there for low-end and medium-end Android…

7 Likes

Cool! I love that it goes faster!

2 Likes

Update: I’m planning to merge this into master today.

After that I’ll be writing up a guide on the new plugin API I’ve developed as well as a blog post about how we achieved the speed increase and why we did it :slightly_smiling:

12 Likes

Thanks for all the good work.

:clap:

1 Like

Thansk for the heads up, I’m updating my instance now, so I can test the vdom before the next update.

Thanks for all the bug reports and patience everyone!

I’ve merged this into master now, and meta is back to deploying from tests-passed!

If you’re a plugin author, be sure to read through our new API information.

14 Likes

I felt a difference on Meta, but damn, I just upgraded my forum and it’s really great.

On my windows phone (Lumia 635), it worked pretty good already but it seems about 10-20% quicker too.

Amazing work guys !

5 Likes

I have I feeling I already read this somewhere but I cannot find it:

When a new post was added to a topic while you were reading it, it isn’t marked as read even if you interact with it e.g. by liking it.

3 Likes

Here’s the blog entry about the upgrade:

12 Likes

There seems to be a hidden “private message” glyph and link in public topics:

Yeah I know it’s hidden - but should it be there?
… I’m having to style it in a couple of my other instances to get rid of it due to the VDOM changes.

2 Likes

That didn’t change due to VDOM. That’s just how our topic is showing/hiding that icon.

That might be the case, however I have had to introduce / change CSS styling for the following since the VDOM change:

  • the glyph link detailed above.
  • time-gaps & actions

@eviltrout

On previous version, I could see a picture with 1200px width (as an example) without any issue.

But after I upgraded to “v1.5.0.beta12 +5”, the picture has been truncated on Desktop browsers (Chrome, Safari, Firefox on desktop). Is this an expected behavior from the bug fix? Fyi I want to see the picture as it was displayed on previous versions.

What do you mean by truncated? I am having a hard time understanding what you wrote.

Thanks for seeing my post; and big thanks for making the Discourse I truly enjoy you and your team’s awesome product!

I am running a K-pop fan forum and the users upload high resolution pics. Here is the one of the sample post the the photo been “truncated”. Please see the second picture of this post: http://mywoohyun.com/t/topic/601

The original photo was uploaded to S3 via Discourse and the original photo is here: https://drvbz9bzfveqj.cloudfront.net/original/2X/7/79171e4d701c47833c8fabd8da0871b9bf98be5b.jpg

2 Likes

@eviltrout probably worth reviewing this and closing, new rendering engine is working really well.

5 Likes