HTTP Range support missing, cannot resume file download

[ValdikSS]

Discourse is missing support for HTTP Range header and always replies with 200 OK code instead of 206 Partial Content for the file downloads. This is inconvenient for the forum users as it forces to redownload the whole file in case of unstable internet connection.

The topic Backup too big, is there a way to download it through "resume download" mentioned this issue in case of backup download, however this also applies to regular file download when S3 storage is not used.

I checked nginx proxy configuration, and it’s not a configuration issue. Range header is properly passed to localhost:3000 for /uploads/short-url/ requests, but Discourse does not handle it.

As HTTP Range is one of the basic HTTP features, filling it under “bug”, not “feature” category.

P.S. it is not reproducible here, on meta.discourse.org, as it uses S3 for storage.

[Falco]

@ValdikSS

Range header is properly passed to localhost:3000 for /uploads/short-url/ requests, but Discourse does not handle it.

That is handled here:

discourse/discourse/blob/10a1b6b0a9e07b1652e23c02f55a32b1b607e722/app/controllers/uploads_controller.rb#L287-L303

Adding support for ranges is definitely possible, but would involve using send_data, and reading the file from disk and sending the range:

rails media file stream accept byte range request through send_data or send_file method

A bit too messy to be honest.