Downloading backups should include Content Length


(Dean Taylor) #1

When downloading backups from the admin page the browser is unable to display a progress bar due to Content Length header not being included.

When backups get large it is difficult to know how far though the download progress we are.

I would like to request content length to be included.

Cheers,
Dean.


Downloaded Backups are invalid (incomplete download)
Downloaded Backups are invalid (incomplete download)
(Robin Ward) #2

@zogstrip this sounds pretty easy in theory. Could we add it?


(Sam Saffron) #3

Are you sure it’s not? When I ran fiddler it seemed to be there


(Dean Taylor) #4

I’m sure @sam

Here is my fiddler output:

And Google Chrome Developer Tools - Network Response headers:


(Sam Saffron) #5

This is fixed:

https://github.com/discourse/discourse/commit/9428ad779f9b58dca30d0096c69822c7a471aefb

Can you see if this fixed the invalid file stuff ?


(Sam Saffron) #6