Ignored user time zone for poll closeDate display

benkeks · April 30, 2020, 5:06pm

The close date of polls that is displayed when hovering the “Closes in …” info prior to closing time seems to be rendered in the server time zone.

One would rather expect it to be displayed in the same time zone as surrounding time info (e.g. the post date).

In the following poll, I set close=2020-05-01T18:00CEST. The hover title should thus render consistent with 2020-05-01T16:00:00Z. (For me, it says 4:00 PM instead of 6:00 PM.)

option1
option2

0 voters

This might seem like a minor ux glitch. But as we are currently conducting binding votes in my community using this feature, it’s quite annoying to have “wrong” end times. I quick-fixed it for my instance by adding a .local() in the display widget JS at:

github.com

discourse/discourse/blob/master/plugins/poll/assets/javascripts/widgets/discourse-poll.js.es6#L750


      icon: "download",
      disabled: poll.voters === 0,
      action: "exportResults"
    })
  );
}


if (poll.get("close")) {
  const closeDate = moment.utc(poll.get("close"));
  if (closeDate.isValid()) {
    const title = closeDate.format("LLL");
    let label;


    if (attrs.isAutomaticallyClosed) {
      const age = relativeAge(closeDate.toDate(), { addAgo: true });
      label = I18n.t("poll.automatic_close.age", { age });
    } else {
      const timeLeft = moment().to(closeDate.local(), true);
      label = I18n.t("poll.automatic_close.closes_in", { timeLeft });
    }

(But I’m not sufficiently familiar with Discourse to tell whether this is actually the right fix. )

codinghorror · May 1, 2020, 8:52pm

cc @joffreyjaffeux perhaps?

joffreyjaffeux · May 1, 2020, 9:09pm

Sure can have a look, don’t know this code, but seems very straightforward, will fix by next week.

joffreyjaffeux · May 6, 2020, 8:24pm

That should fix it

joffreyjaffeux · May 7, 2020, 8:17pm

This topic was automatically closed 24 hours after the last reply. New replies are no longer allowed.