Improved Bookmarks with Reminders

That’s awesome, thank you!

2 Likes

The final PR is now merged. We should have a new beta out in the next day or so. There are now no outstanding issues with the new bookmarks :star2:.

https://github.com/discourse/discourse/pull/9579

14 Likes

Excited to use with the new release. Just 1 question.

  • Do the bookmark reminder notification send email (if the user is not logged in)?
1 Like

You will get a count of unread high priority notifications in your user digest email (which bookmark reminders contribute to) but apart from that no, you receive no reminder via email.

You can also sync bookmarks with your calendar Sync Bookmark Reminders with your favorite Calendar app.

4 Likes

I have just merged in another change that will be live on Meta within a couple of hours. There is now a hidden option in the bookmark modal that will delete the bookmark once the reminder has been sent. We remember which option you choose in local storage, so this behaviour will be the same for each bookmark you create.

image

https://github.com/discourse/discourse/pull/9637

9 Likes

The idea that people would use browser bookmarks amuses me, so I’m very glad that Discourse still has a bookmarks feature. I frequently bookmark posts here, but it would never occur to me to add a bookmark to my browser. Guess I’m weird.

3 Likes

I’ve added another PR now that fixes the issue here Domain.com/bookmarks is showing domain.com/u/user/activity/bookmarks-with-reminders, and also adds the bookmarked post user avatar to the bookmarks list. It will be merged soon:

https://github.com/discourse/discourse/pull/9759

cc @Ellibereth , I know in an earlier post you mentioned you wanted to see the avatars, and @exetico for the URL change.

11 Likes

I’d be nice if the “What is this bookmark for” field’s information was utilized more. Right now the only way to see that information is from the full bookmark list in your profile or opening the bookmark itself. I think it would be more useful if it was used in the bookmark list from the dropdown menu and/or if it was included in the reminder notification.

4 Likes

Reminders don’t have any extra info so how do you see that working? Add an entirely new area of functionality, just for this?

3 Likes

Rather, I wonder if the text in that field (if set) should replace the topic title in the notification. Just a thought.

7 Likes

I somewhat agree with you. This may not be very obvious, but you can see the “what is this bookmark for” information when you hover over the reminder notification. We already have the information when we notify, but we didn’t want to create a different notification format just for this feature.

9 Likes

I didn’t realize that. Thanks for the tip!

6 Likes

I see a couple places that are awkward with the new bookmarks functioning:

In the /u/name/notifications view, bookmarks are shown but they are missing from the filter options (which only have responses, likes, mentions, and edits).

In the /u/name/activity/bookmarks view, the only dates indicated are for future reminders. It would be preferable to show the past dates as well (nice to know how long it’s been since the reminder was triggered), but that should be distinct visually. And it would be great to have the ability to filter to only see future or only past-date bookmarks when in that view.

3 Likes

This shouldn’t be too hard because we have a reminder_last_sent_at column.

Thanks for reporting this; we also intend to make it so the bookmark reminder notifications stick to the top of this page like unread PM notifications.

6 Likes

Hey guys

Are there any plans to add a feature to share bookmarks with other users?
We want to utilize it for our staff

1 Like

I would love for reoccurring bookmarks to be added (reminder every hour, reminder every single day, reminder every week, reminder every month, reminder every year, custom time frame, etc).

4 Likes

I have a use case for that. I have a PM that I use for keeping track of my daily activity on this site. I bookmark the PM every day to remind myself to add my update. Sometimes I forget to set the bookmark for the next day. A recurring bookmark would solve the problem. I’m not sure how common of a use case this is though.

6 Likes

I have a similar use case (Christmas countdown and countdowns in general). It would make my life so much easier. Part of me really hopes that it will be added in the near future. :slight_smile:

2 Likes

I have a use case for creating a new recurring topic on a weekly basis, so I would also benefit from recurring bookmark reminders.

4 Likes

Not sure what you mean by this, can you expand a bit? Do you mean setting bookmark reminders for other staff?

We are also contemplating recurring reminders, but I am not sure where that is at right now. Will discuss further internally.

3 Likes