Improved Bookmarks with Reminders

I am actually against a site setting here, you can post a theme component though if you feel like it

4 Likes

No, there is no way to do this at the moment. Sorry!

3 Likes

Additionally, any customization restoring the old behavior is going to be unstable until all the cleanup work (changing usages of bookmarkWithReminder to just bookmark) is done.

1 Like

I think it also worth mentioning that the old behavior was that we had a button almost nobody ever clicked that performed an action nobody really cared about. And we have plenty of stats to back that up.

I am very much against ā€œrestoring old behaviorā€ cause people ā€¦ have reasonsā€¦

If your really hate bookmarks why not just disable bookmarks.

10 Likes

Yes exactly, just remove it from the list of commands on the post if you really want to be rid of bookmark. Itā€™s kind of a useless feature as it existed before anywayā€¦ literally the only thing it was good for is cross-browser cross OS ā€œbookmarksā€ which is such a narrow use case.

7 Likes

Ok, so following the ā€œtheme componentā€ route is the right way to get this done? Iā€™m not going to try to convince yā€™all to do thisā€¦ but I hope itā€™s okay to ask for some guidance on how I can accomplish this for my setup.

Noted.

1 Like

It was a productive day today. The following PRs were merged, and all except the last is now live on Meta:

https://github.com/discourse/discourse/pull/9548
https://github.com/discourse/discourse/pull/9547
https://github.com/discourse/discourse/pull/9563

And https://github.com/discourse/discourse/pull/9541 should be merged soon. I also have a PR up to change the /bookmarks-with-reminders URL back to /bookmarks, hoping to merge that tomorrow https://github.com/discourse/discourse/pull/9566.

The ā€œTopic user bookmarked column logic was not correctā€ fix should be live on Meta in the next couple of hours. Later this week we will be cutting another beta release for all of these fixes.

18 Likes

Another update ā€“ both of these PRs are now merged and there are no outstanding bugs. I am now just working on a final PR to rename variables etc. like bookmarkWithReminder back to bookmark.

https://github.com/discourse/discourse/pull/9541
https://github.com/discourse/discourse/pull/9566

12 Likes

Iā€™ve implemented single click, no dialogue, bookmarking from the Topic List in the Topic List Previews plugin (which still allows you to use rich bookmarking from Topics)

It might not be stable for a few days as I try to keep pace with all the core changes but yesterday it was working!

5 Likes

Thatā€™s awesome, thank you!

2 Likes

The final PR is now merged. We should have a new beta out in the next day or so. There are now no outstanding issues with the new bookmarks :star2:.

https://github.com/discourse/discourse/pull/9579

14 Likes

Excited to use with the new release. Just 1 question.

  • Do the bookmark reminder notification send email (if the user is not logged in)?
1 Like

You will get a count of unread high priority notifications in your user digest email (which bookmark reminders contribute to) but apart from that no, you receive no reminder via email.

You can also sync bookmarks with your calendar Sync Bookmark Reminders with your favorite Calendar app.

4 Likes

I have just merged in another change that will be live on Meta within a couple of hours. There is now a hidden option in the bookmark modal that will delete the bookmark once the reminder has been sent. We remember which option you choose in local storage, so this behaviour will be the same for each bookmark you create.

image

https://github.com/discourse/discourse/pull/9637

9 Likes

The idea that people would use browser bookmarks amuses me, so Iā€™m very glad that Discourse still has a bookmarks feature. I frequently bookmark posts here, but it would never occur to me to add a bookmark to my browser. Guess Iā€™m weird.

3 Likes

Iā€™ve added another PR now that fixes the issue here Domain.com/bookmarks is showing domain.com/u/user/activity/bookmarks-with-reminders, and also adds the bookmarked post user avatar to the bookmarks list. It will be merged soon:

https://github.com/discourse/discourse/pull/9759

cc @Ellibereth , I know in an earlier post you mentioned you wanted to see the avatars, and @exetico for the URL change.

11 Likes

Iā€™d be nice if the ā€œWhat is this bookmark forā€ fieldā€™s information was utilized more. Right now the only way to see that information is from the full bookmark list in your profile or opening the bookmark itself. I think it would be more useful if it was used in the bookmark list from the dropdown menu and/or if it was included in the reminder notification.

4 Likes

Reminders donā€™t have any extra info so how do you see that working? Add an entirely new area of functionality, just for this?

3 Likes

Rather, I wonder if the text in that field (if set) should replace the topic title in the notification. Just a thought.

7 Likes

I somewhat agree with you. This may not be very obvious, but you can see the ā€œwhat is this bookmark forā€ information when you hover over the reminder notification. We already have the information when we notify, but we didnā€™t want to create a different notification format just for this feature.

9 Likes