Несовместимость плагинов Cakeday, Data-Explorer и Animated Avatar

piffy · 31.Декабрь.2022 09:43:44

У меня установлены оба этих плагина.
URL-адрес для просмотра юбилеев (/cakeday/anniversaries/today) выдаёт следующую ошибку:

Полные логи:

activemodel (7.0.3.1) lib/active_model/attribute.rb:226:in `value'
activemodel (7.0.3.1) lib/active_model/attribute_set/builder.rb:55:in `block in fetch_value'
activemodel (7.0.3.1) lib/active_model/attribute_set/builder.rb:46:in `fetch'
activemodel (7.0.3.1) lib/active_model/attribute_set/builder.rb:46:in `fetch_value'
activerecord (7.0.3.1) lib/active_record/attribute_methods/read.rb:38:in `_read_attribute'
activemodel (7.0.3.1) lib/active_model/attribute_methods.rb:277:in `admin'
app/models/concerns/roleable.rb:14:in `staff?'
plugins/discourse-animated-avatars/plugin.rb:90:in `block (2 levels) in activate!'
lib/plugin/instance.rb:285:in `public_send'
lib/plugin/instance.rb:285:in `block (2 levels) in add_to_class'
activesupport (7.0.3.1) lib/active_support/core_ext/object/try.rb:15:in `public_send'
activesupport (7.0.3.1) lib/active_support/core_ext/object/try.rb:15:in `try'
plugins/discourse-animated-avatars/plugin.rb:94:in `block (2 levels) in activate!'
(eval):7:in `_fast_attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:468:in `rescue in attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:455:in `attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:480:in `_serializable_hash'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:359:in `serializable_hash'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:89:in `block in _serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:79:in `map'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:79:in `_serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:73:in `serializable_array'
active_model_serializers (0.8.4) lib/active_model/array_serializer.rb:53:in `as_json'
app/controllers/application_controller.rb:519:in `serialize_data'
plugins/discourse-cakeday/app/controllers/discourse_cakeday/anniversaries_controller.rb:53:in `index'
actionpack (7.0.3.1) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
actionpack (7.0.3.1) lib/abstract_controller/base.rb:215:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/rendering.rb:53:in `process_action'
actionpack (7.0.3.1) lib/abstract_controller/callbacks.rb:234:in `block in process_action'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:118:in `block in run_callbacks'
app/controllers/application_controller.rb:413:in `block in with_resolved_locale'
i18n (1.12.0) lib/i18n.rb:322:in `with_locale'
app/controllers/application_controller.rb:413:in `with_resolved_locale'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:127:in `block in run_callbacks'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:138:in `run_callbacks'
actionpack (7.0.3.1) lib/abstract_controller/callbacks.rb:233:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/rescue.rb:22:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/instrumentation.rb:67:in `block in process_action'
activesupport (7.0.3.1) lib/active_support/notifications.rb:206:in `block in instrument'
activesupport (7.0.3.1) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
activesupport (7.0.3.1) lib/active_support/notifications.rb:206:in `instrument'
actionpack (7.0.3.1) lib/action_controller/metal/instrumentation.rb:66:in `process_action'
actionpack (7.0.3.1) lib/action_controller/metal/params_wrapper.rb:259:in `process_action'
activerecord (7.0.3.1) lib/active_record/railties/controller_runtime.rb:27:in `process_action'
actionpack (7.0.3.1) lib/abstract_controller/base.rb:151:in `process'
actionview (7.0.3.1) lib/action_view/rendering.rb:39:in `process'
rack-mini-profiler (3.0.0) lib/mini_profiler/profiling_methods.rb:111:in `block in profile_method'
actionpack (7.0.3.1) lib/action_controller/metal.rb:188:in `dispatch'
actionpack (7.0.3.1) lib/action_controller/metal.rb:251:in `dispatch'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:50:in `block in serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:852:in `call'
railties (7.0.3.1) lib/rails/engine.rb:530:in `call'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `method_missing'
actionpack (7.0.3.1) lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>'
actionpack (7.0.3.1) lib/action_dispatch/routing/mapper.rb:48:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:50:in `block in serve'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (7.0.3.1) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (7.0.3.1) lib/action_dispatch/routing/route_set.rb:852:in `call'
lib/middleware/omniauth_bypass_middleware.rb:71:in `call'
rack (2.2.4) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.2.4) lib/rack/conditional_get.rb:27:in `call'
rack (2.2.4) lib/rack/head.rb:12:in `call'
actionpack (7.0.3.1) lib/action_dispatch/http/permissions_policy.rb:38:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
rack (2.2.4) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.4) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/cookies.rb:697:in `call'
activerecord (7.0.3.1) lib/active_record/migration.rb:603:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (7.0.3.1) lib/active_support/callbacks.rb:99:in `run_callbacks'
actionpack (7.0.3.1) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/debug_exceptions.rb:28:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/show_exceptions.rb:26:in `call'
logster (2.11.3) lib/logster/middleware/reporter.rb:43:in `call'
railties (7.0.3.1) lib/rails/rack/logger.rb:40:in `call_app'
railties (7.0.3.1) lib/rails/rack/logger.rb:27:in `call'
config/initializers/100-quiet_logger.rb:23:in `call'
config/initializers/100-silence_logger.rb:31:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/remote_ip.rb:93:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/request_id.rb:26:in `call'
rack (2.2.4) lib/rack/method_override.rb:24:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/static.rb:23:in `call'
rack (2.2.4) lib/rack/sendfile.rb:110:in `call'
actionpack (7.0.3.1) lib/action_dispatch/middleware/host_authorization.rb:137:in `call'
lib/middleware/missing_avatars.rb:23:in `call'
lib/middleware/turbo_dev.rb:34:in `call'
rack-mini-profiler (3.0.0) lib/mini_profiler/profiler.rb:393:in `call'
message_bus (4.3.0) lib/message_bus/rack/middleware.rb:60:in `call'
railties (7.0.3.1) lib/rails/engine.rb:530:in `call'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.3.1) lib/rails/railtie.rb:226:in `method_missing'
rack (2.2.4) lib/rack/urlmap.rb:74:in `block in call'
rack (2.2.4) lib/rack/urlmap.rb:58:in `each'
rack (2.2.4) lib/rack/urlmap.rb:58:in `call'
unicorn (6.1.0) lib/unicorn/http_server.rb:634:in `process_client'
unicorn (6.1.0) lib/unicorn/http_server.rb:739:in `worker_loop'
unicorn (6.1.0) lib/unicorn/http_server.rb:547:in `spawn_missing_workers'
unicorn (6.1.0) lib/unicorn/http_server.rb:143:in `start'
unicorn (6.1.0) bin/unicorn:128:in `<top (required)>'
bin/unicorn:96:in `load'
bin/unicorn:96:in `block in <main>'
bin/unicorn:95:in `fork'
bin/unicorn:95:in `<main>'

Я попытался разобраться в точной причине этой проблемы. На мой взгляд, наиболее релевантные строки здесь:

app/models/concerns/roleable.rb:14:in `staff?'
plugins/discourse-animated-avatars/plugin.rb:90:in `block (2 levels) in activate!'
...
plugins/discourse-animated-avatars/plugin.rb:94:in `block (2 levels) in activate!'
...
app/controllers/application_controller.rb:519:in `serialize_data'
plugins/discourse-cakeday/app/controllers/discourse_cakeday/anniversaries_controller.rb:53:in `index'

Похоже, что проблема заключается в том, что при вызове функции «staff?» она отсутствует у объекта пользователя, на который здесь ссылаются, из-за чего в плагине Animated Avatar возникает ошибка:

github.com/discourse/discourse-animated-avatars

plugin.rb

main


      
          # frozen_string_literal: true
          # name: discourse-animated-avatars
          # about: This plugin adds support for animated avatars
          # version: 0.1
          # url: https://github.com/discourse/discourse-animated-avatars
          
          after_initialize do
            require_relative "lib/discourse_animated_avatars/upload_creator_gifsicle_extension"
            require_relative "lib/discourse_animated_avatars/upload_creator_no_gifsicle_extension"
            require_relative "lib/discourse_animated_avatars/optimized_image_extension"
            require_relative "lib/discourse_animated_avatars/user_avatars_controller_extension"
          
            reloadable_patch do
              gifsicle_installed =
                begin
                  Discourse::Utils.execute_command(
                    "gifsicle",
                    "--version",
                    "&>",
                    "/dev/null",
                    failure_message: "gifsicle not found",
                  )
                  true
                rescue StandardError
                  false
                end
          
              # new crop functions if gifsicle is installed
              if gifsicle_installed
                UploadCreator.prepend(DiscourseAnimatedAvatars::UploadCreatorGifsicleExtension)
              else
                # fallback if no gifsicle, no cropping for animated avatars
                UploadCreator.prepend(DiscourseAnimatedAvatars::UploadCreatorNoGifsicleExtension)
              end
          
              OptimizedImage.prepend(DiscourseAnimatedAvatars::OptimizedImageExtension)
              UserAvatarsController.prepend(DiscourseAnimatedAvatars::UserAvatarsControllerExtension)
            end
          
            add_to_class(:user, :animated_avatar) do
              pass_tl_check = staff? || trust_level >= SiteSetting.animated_avatars_min_trust_level_to_display
              uploaded_avatar&.url if uploaded_avatar&.animated? && pass_tl_check
            end
          
            add_to_serializer(:basic_user, :animated_avatar) do
              user.try(:animated_avatar)
            rescue StandardError
              nil
            end
            add_to_serializer(:post, :animated_avatar) do
              object.user.try(:animated_avatar)
            rescue StandardError
              nil
            end
          end
          
          Discourse::Application.routes.append do
            get "user_avatar/:hostname/:username/:size/:version.gif" => "user_avatars#show",
                :constraints => {
                  hostname: /[\w\.-]+/,
                  size: /\d+/,
                  username: RouteFormat.username,
                  format: :gif,
                }
          end

Это восходит к плагину Cakeday, когда происходит сериализация списка пользователей:

github.com/discourse/discourse-cakeday

app/controllers/discourse_cakeday/anniversaries_controller.rb

main


      
          # frozen_string_literal: true
          
          module DiscourseCakeday
            class AnniversariesController < CakedayController
              before_action :ensure_cakeday_enabled
          
              def index
                column_sql = "created_at"
          
                # The users.created_at column is a "timestamp without timezone"
                # so we need to convert the "point in time" to the current user's timezone
                # for proper filtering and display (otherwise you might get off by ones
                # if you live in ~~the future~~ Fiji or in ~~the past~~ Hawaii)
                if @timezone.present? && @timezone != "UTC"
                  column_sql += " AT TIME ZONE 'UTC' AT TIME ZONE '#{@timezone}'"
                end
          
                users, total, more_params = cakedays_by(column_sql, at_least_one_year_old: true)
          
                render_json_dump(
                  anniversaries: serialize_data(users, CakedayUserSerializer),
                  total_rows_anniversaries: total,
                  load_more_anniversaries: anniversaries_path(more_params),
                )
              end
          
              private
          
              def ensure_cakeday_enabled
                raise Discourse::NotFound if !SiteSetting.cakeday_enabled
              end
            end
          end

Теперь, я не эксперт в том, как именно работает сериализация здесь, но если бы мне пришлось дать приблизительный диагноз, то это выглядело бы так: плагину Animated Avatar передаётся объект «user», у которого отсутствуют некоторые ожидаемые свойства объекта пользователя, а именно функция staff? (а также trust_level, что я выяснил). Думаю, воспроизвести эту ошибку может быть немного сложно, так как для этого необходимо, чтобы на странице /cakeday/anniversaries/today отображались пользователи, что было нетривиально добиться на моём экземпляре разработки.

На моём рабочем форуме я также подтвердил, что эта проблема сохраняется в безопасном режиме (только официальные плагины).

Аналогичная проблема сообщается здесь: Discourse Cakeday - #200

JammyDodger · 11.Январь.2023 13:03:03

Привет @piffy

Кстати, я установил Animated Avatars на свой тестовый сайт (вместе с Cakeday ) и думаю, что могу воспроизвести эту ошибку.

Установите и активируйте оба плагина
Используйте удобный код в консоли Rails ^[1], чтобы установить дату присоединения тестового пользователя на год назад
Перейдите по адресу /cakeday/anniversaries/today
Ошибка 500

Сообщение (4 сообщения)

ActiveModel::MissingAttributeError (отсутствует атрибут: admin)
app/models/concerns/roleable.rb:14:in `staff?'
lib/plugin/instance.rb:297:in `public_send'
lib/plugin/instance.rb:297:in `block (2 levels) in add_to_class'
(eval):8:in `_fast_attributes'
app/controllers/application_controller.rb:521:in `serialize_data'
app/controllers/application_controller.rb:414:in `block in with_resolved_locale'
app/controllers/application_controller.rb:414:in `with_resolved_locale'
lib/middleware/omniauth_bypass_middleware.rb:74:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:366:in `call'
config/initializers/100-quiet_logger.rb:20:in `call'
config/initializers/100-silence_logger.rb:29:in `call'
lib/middleware/enforce_hostname.rb:24:in `call'
lib/middleware/request_tracker.rb:228:in `call'

Обратная трассировка

activemodel (7.0.3.1) lib/active_model/attribute.rb:226:in `value'
activemodel (7.0.3.1) lib/active_model/attribute_set/builder.rb:43:in `fetch_value'
activerecord (7.0.3.1) lib/active_record/attribute_methods/read.rb:38:in `_read_attribute'
activemodel (7.0.3.1) lib/active_model/attribute_methods.rb:277:in `admin'
app/models/concerns/roleable.rb:14:in `staff?'
plugins/discourse-animated-avatars/plugin.rb:90:in `block (2 levels) in activate!'
lib/plugin/instance.rb:297:in `public_send'
lib/plugin/instance.rb:297:in `block (2 levels) in add_to_class'
activesupport (7.0.3.1) lib/active_support/core_ext/object/try.rb:15:in `public_send'
activesupport (7.0.3.1) lib/active_support/core_ext/object/try.rb:15:in `try'

Я подумал, что попробую более простой способ и сделаю то же самое для дней рождения, чтобы избежать возни в консоли Rails, но /cakeday/birthdays/today работал нормально.

user = User.where(username: ‘Test_Three’)
user.update(created_at: “2022-01-11 00:00:00.00000”) ↩︎

david · 11.Январь.2023 13:23:50

Это также, похоже, влияет на data-explorer, см.

featheredtoast · 12.Январь.2023 00:45:22

Привет, @piffy, большое спасибо за подробный отчёт — я обновил совместимость плагинов с помощью этого PR:

Мне удалось перейти на страницу директории cakeday через мои тесты, но дайте знать, если остались какие-либо нерешённые вопросы.

piffy · 12.Январь.2023 03:14:52

Для меня это работает! Большое спасибо!!

Тема		Ответов	Просм.
Animated Avatar Plugin experimental	48	11045	04.04.2025
Discourse Cakeday Plugin official , cakeday	22	30584	07.04.2026
Cakeday crashes at api call on unauthenticated users Bug cakeday	3	519	27.09.2023
Error 500 when opening Cakeday URL Support cakeday	3	287	01.01.2023
The Missing Public Profiles Mystery [Animated Avatars] Support	9	665	28.09.2023

Несовместимость плагинов Cakeday, Data-Explorer и Animated Avatar

Связанные темы