Inconsistency in plural definition

flink91 · July 26, 2024, 10:27am

Another patch has just been merged:

github.com/discourse/discourse

FIX: Validate MF strings when adding overrides

discourse:main ← discourse:loic-validate-translation-overrides

opened 03:00PM - 25 Jul 24 UTC

Flink

+103 -21

Currently, when adding translation overrides, values aren’t validated for MF str…ings. This results in being able to add invalid plural keys or even strings containing invalid syntax. This PR addresses this issue by compiling the string when saving an override if the key is detected as an MF one. If there’s an error from the compiler, it’s added to the model errors, which in turn is displayed to the user in the admin UI, helping them to understand what went wrong. ---- ![image](https://github.com/user-attachments/assets/7315f643-b764-411b-b962-92dac0cd0b20) ![image](https://github.com/user-attachments/assets/bb22c536-5bda-4f5f-8be6-6171b4427245)

This will prevent creating invalid MF overrides in the admin UI.

Topic		Replies	Views
Issue with pluralized (count) translation override bug translation , fixed	10	104	July 22, 2024
Overridden translation sticking after being pluralized bug translation	4	287	August 2, 2024
Always use %{count} variable when translating pluralized strings translations	7	2817	May 20, 2019
Number pluralization 'one' category misused translations	1	1278	August 29, 2018
Locale fallback to English doesn't work for pluralized strings bug	4	1062	February 28, 2017

Inconsistency in plural definition

Related Topics