Incorrect message key in temporarily closed topic

Temporarily closing a topic in a category set to ‘Close X hours after last post’ leads to an incorrect message key:

Reproduction steps:

have category with auto-close-based-on-last-post settings such as:

image

create topic:

close topic temporarily:

result:

It’s picking up the fact that the topic closing time is based_on_last_post but applying it to the auto_open state, which is incorrect.


Another path that leads to this result:

  • close topic
  • set auto-reopen

This problem seems due to client confusion. I never got a 502 error but there definitely is some weirdness coming here from the client, e.g. this timers XHR call:

based_on_last_post:true
category_id:null
closed:true
duration:2018
execute_at:"2018-08-09T16:16:14.873Z"
success:"OK"

3 months in the future? :confused:

5 Likes

Fixed in

https://github.com/discourse/discourse/commit/2fecb4b46e7fea0e2e3cb2adbbfe83b6a77f1a23

6 Likes