Inline PDF Previews

theme-component
, ,
55

Excellent! Thanks @Johani. I can confirm it works in all 3 browsers now.

4 Likes
56

Fantastic - these are solid improvements and clearly a lot of work to achieve. Thanks for listening to us slightly annoying co-conspirators in the self-hosted world!

Does the Component now work with S3 uploads?

3 Likes
57

I havenā€™t tried it, but It should work if your bucket is configured correctly. This component makes a request to load the PDF

discourse-pdf-previews/initialize-for-pdf-preview.js at main Ā· discourse/discourse-pdf-previews Ā· GitHub

These types of requests made in JavaScript are blocked if the origin is not allowed access to the file. You then end up with a CORS error. If you check the console, youā€™ll probably see something along the lines of this.

image

Thereā€™s not much the component can do about this. It all has to be handled in your S3 configuration. The origin - your Discourse domain - must be allowed to make such requests to avoid CORS issues.

9 Likes
58

Thanks! Iā€™ll bravely take the plunge back to S3 shortly.

Another suggestion: tab when space before filename

What I want is for the pdf to be inline by default, and to open in a new tab if the space is put in the filename. This gives authors the choice per pdf of inline vs tab rather than per component.

Perhaps the component setting should instead be ā€œWhat default behaviour do you want?ā€ and if a space is put in you get the other.

Or alternatively you could ask what the space should do (inline / tab / download).

2 Likes
59

Aargh! Chrome is again showing only gray boxes. FF and Safari are OK.

3 Likes
60

Is this theme component sending the pdf to external interpreter?
I have ā€œsecure mediaā€ enabled because i want to avoid files being loaded by an external serviceā€¦

1 Like
61

I found out that this is because of the following code:

<a class="attachment pdf-attachment" href="...pdf">doc.pdf
  <iframe src="blob:..." height="500" loading="lazy" class="pdf-preview">
  </iframe>
</a>

If you replace the above code with the following:

<a class="attachment pdf-attachment" href="...pdf">doc.pdf</a>
<iframe src="blob:..." height="500" loading="lazy" class="pdf-preview"></iframe>

It will work
But Iā€™m not sure how to fix this in the existing code.

5 Likes
62

@Johani
The error is associated with the following code, line 34 - 41:

        const setUpPreviewType = (pdf) => {
          if (previewMode === "Inline") {
            const preview = createPreviewElement();
            pdf.classList.add("pdf-attachment");
            pdf.append(preview);

            return preview;
          }
4 Likes
63

This solution seems to work for all browsers.

4 Likes
64

pdf.parentNode.append(preview); seems to do the trick (but in case of multiple pdfs, previews show below all links, not below each one)

3 Likes
65

But if the parentNode is the paragraph, than this shouldnā€™t be an issue because the link and the iframe will be inside the paragraph tag.

So to bypass this issue you can just add a newline between the attachments:

[doc1.pdf|attachment](...)

[doc2.pdf|attachment](...)

and with your solution it will properly display the PDF preview on Chrome as well

3 Likes
66

I just pushed some changes.

Yeah, that makes more sense than ignoring the file. Hereā€™s how things will work after the update.

  1. If you set the setting to ā€œNew Tab,ā€ the component wonā€™t attach any preview in posts. If you click the link, it will open the PDF in a new tab.

  2. If you set the setting to ā€œInline,ā€ the component will attach a preview in the post to all PDFs by default. If the file name starts with a space, it wonā€™t attach the preview, but clicking the link will open the PDF in a new tab instead of downloading it.

    All native browser PDF viewers have a download button, so you can download it from there if you want to.

Thanks for the debugging and details @sharewoodsDavid. It turns out that <iframe> tags inside <a> tags fails to validate

The element iframe must not appear as a descendant of the a element

So, your fix is on point. I made that change in the PR above.

If you want to add an element after another element, you can use after() like so

someElement.after(newElement)

If you want to add an element before another element, you can use insertBefore() like so

// parentNode: the parent of the element you want to insert before
// newNode: the element you want to insert
// referenceNode: the element you want to insert before

parentNode.insertBefore(newNode, referenceNode)

No. There are no external services involved in this. Hereā€™s how it works.

  1. user visits a post with a PDF attachment
  2. userā€™s browser requests the attachment
  3. server sends it to the userā€™s browser
  4. the userā€™s browser reads it using the built-in PDF viewer

Thatā€™s it.

7 Likes
67

Perfect - thanks @Johani. Confirming it works in Chrome, FF, and Safari. :+1:

3 Likes
68

This is great! Thank you so much. Iā€™ve got it installed and working! Just what I was looking for.

5 Likes
69

Will this be retroactive to pdfs already posted in the forum?

2 Likes
70

I have just tested on my test site, and it appears it works for the existing ones too, without needing to ā€˜rebuild htmlā€™. :+1:

6 Likes
71

I saw an update in the source last week so Iā€™m guessing this component is alive. But sadly it has never worked for me on any browser. Is it because of secure ā€œmedia settingā€ maybe?
Am I the only one who canā€™t get this to work or this is a common issue?

2 Likes
72

Never worked for me either.

2 Likes
73

The component works well. What issue/error are you seeing?

3 Likes
74

I saw only ordinary download link of a file. I didnā€™t start dig any deeper because it wasnā€™t that important for me, it would be nice to have, nothing else. So, sorry but I canā€™t light this more.

Edit

Well, I checked again ā€” last time was some time ago.

DiscourseHub shows this (iPad), and no errors in logs of Discourse:

image
image2048Ɨ1536 177 KB

But when I tried using Safari it showed very first page, but not second.

1 Like