@Roman_Rizzi can you add investigating this to your list (once you free us from other work)
5 Likes
Just pushed a fix:
https://github.com/discourse/onebox/commit/912d579ae3b1331f6dedcc9724e6c9ed0ddb289f
Will bump onebox version in discourse soon.
8 Likes
https://www.instagram.com/bennyblood24/p/BvRvyluBbwU
The fix is now live on meta:
9 Likes
Hi Sam, is Instagram oneboxing broken? Test:
1 Like
You wrote
https://www.instagram.com/p/BwrDFZ8AbBy/?utm_source=ig_web_button_share_sheet
But let’s see
https://www.instagram.com/p/BwrDFZ8AbBy/
3 Likes
@Roman_Rizzi Looks like updated regex for username broke the regular Instagram links. Can you fix?
5 Likes
I relaxed the regexp a little bit and added an additional test to cover both cases.
https://www.instagram.com/p/BwieEVwgYZq/
https://www.instagram.com/meowed/p/Bw1WjpcDXRU/
12 Likes
Following up here as I’ve noticed broken Instagram oneboxes on our site…
Is this supposed to make it so that the Instagram onebox preview images no longer break? Because if so, it seems that’s not currently working for us. It may be specific to video posts (not sure as pretty much all examples on our site are videos).
See e.g. this post on our site (from just a few weeks ago): Forearm rotation clip on this blog? - Playing Technique - The Cracking the Code Forum
Same with several others. Rebuild does fix, e.g. displays like so after rebuilding the post: Black star lick HELP ME - Playing Technique - The Cracking the Code Forum
I see some video embeds above in this very topic do still work, so not sure if there’s some other variable with this only happening for certain accounts.
If this is an intentional thing from Instagram without an easy workaround, this is a good suggestion:
Basically — a daily / weekly job (not sure how long exactly the Instagram embeds expire) to run Rebake all posts matching a pattern matching https://www.instagram.com/p/ I think would do the trick.
It should only be much older posts, not a recurring thing. So a one time global rebake should fix all.
Right that’s what I thought at first, and I did a rebake on all our posts w/ Instagram links like a month or two back which I thought would fix this permanently.
But even recent posts (examples: one, two, three) now have the broken preview images again.
Hey Brendan, can you verify that the setting download remote images to local is enabled on your site? Also can you make sure that download remote images threshold is satisfied on your server, i.e. your server has required percentage of minimum disk space?
4 Likes
Server has space, but looks like we did not have that setting enabled, I will turn it on now and run the rebake again. Thanks for the help here!
4 Likes
Following up here, I found that after enabling download remote images to local (with plenty of disk space free) and rebaking, the Instagram onebox preview images were still breaking.
EDIT: ahhh as I’m writing this I think I see what’s going on.
Newer Instagram posts did have the correct image URLs from our domain, while older ones still had the expiring Instagram ones. When I did the rebake for all old embeds, I didn’t realize the site setting download remote images max days old (default 30 days) was limiting this.
So I changed that setting to 9999 and did the rebake again, seems to be working now! (Leaving this rubber-ducking post here just in case this helps clarify for anyone else…)
3 Likes
Instagram onebox doesn’t have video playing and showing album images seperetaly (or sliding) features. Twitter onebox have both. Maybe these could be improved.
Not possible due to IG policies. They are owned by Facebook, who are a-holes about this stuff.
7 Likes
I didn’t know that. Thank you.
Looks like Instagram oneboxing is broken?
Let’s see
Looks fine to me?
9 Likes
doesn’t work for me when I try to put it.