On iPad, this banner is not great. The banner appears at the bottom of the screen, but the share button is at the top. I see there’s a little up arrow , as if to indicate “hey, the button’s up in the header” but I doubt that will be enough. (Have y’all done user testing on this? Have you seen it work for non-expert iPad users?)
It also doesn’t help that we’re asking the user to “tap share,” but the button isn’t visibly called “share.” It’s a little box with an arrow.
I’d love it if Discourse did something more like this.
Now, the flyout is kinda fragile (what if the button moves?), but I think it’s also OK if the button isn’t exactly where the flyout points, as long as it’s in roughly the right place.
Historically, it was also perilous that the button might look different from one version of iOS to the next. But the share button hasn’t changed shape since iOS 7, and there’s no particular reason to think it will change in iOS 17, so I think an approach like this would work on iPad, with a little flyout pointing toward where the Share button probably is in the header bar.
I could see the benefit of showing this flyout at the top of the page when an ipad is being used.
To be quit frank, the reason we didn’t include that icon in this version of the component is that this icon is only available in Font-Awesome 6, and Discourse does not currently support that version yet.
I completely (but I hope politely) disagree. I run a Discourse forum and have it and others added to the Home Screen. I only thought about doing that after discussions here, and haven’t seen any benefits (the notifications don’t work) so have continued to use the Hub app.
My feedback has been specifically from clients, after mentioning that the PWA was a necessary step to enable notifications.
It’s going to vary between communities, but in the era of ‘ask app not to track’ users aren’t as likely to blindly follow instructions without some perceived benefit. Telling a user how to install the PWA without explaining why definitely buries the lede.
I had this issue with a couple of my self-hosted instances and modifying the push notification time window mins to 0 fixed it for me and most of my users. As a side-effect it also makes the behavior closer to how the Hub app notifications work for timing.
Nice component! I like how it’s implemented close to where the share buttons are. Agree that we should integrate this into core and the android banner.
I have an old unimplemented mockup from a while ago that might address some thoughts mentioned here:
The idea with the text here was to have some sort of clear “what’s in it for me” — and literally show the site logo in an app-like way to make it a little clearer what this is all about.
That was mocked up for Android, which makes things easier because you can include a button that directly adds the PWA to your device.
Unfortunately iOS still requires you to go through their share sheet to get to this action… but I think we can have a button that triggers the share options? (we already do this for clicking the share icon on posts in iOS…)
Not on iOS. You can open a share sheet with navigator.share(), but it doesn’t have the “Add to Home Screen” button on it. To A2HS, the user has to manually click the little share button; hence the need for something like this.
I agree, as this is the main benefit for privately-hosted sites (compared with the Hub app).
But does the code check that the iOS version is 16.4 or greater? No point mentioning notifications if not (and arguably little point mentioning A2HS at all). I don’t know Ruby but it seems just to check whether you’re on an iPhone or iPad: