Issue with pluralized (count) translation override

Lhc_fl · July 16, 2024, 2:37am

I found the cause of the issue. Discourse’s I18n relies on the plural definition of an external library:

discourse/discourse/blob/main/app/assets/javascripts/discourse-i18n/src/index.js#L7


      
          if (window.I18n) {
            throw new Error(
              "I18n already defined, discourse-i18n unexpectedly loaded twice!"
            );
          }
          
          import * as Cardinals from "make-plural/cardinals";
          
          // The placeholder format. Accepts `{{placeholder}}` and `%{placeholder}`.
          const PLACEHOLDER = /(?:\{\{|%\{)(.*?)(?:\}\}?)/gm;
          const SEPARATOR = ".";
          
          export class I18n {
            // Set default locale to english
            defaultLocale = "en";
          
            // Set current locale to null

But in this library, we can see that Hungarian is defined as using type a-class plurals, which distinguish between one and other.

github.com

eemeli/make-plural/blob/main/packages/plurals/cardinals.js#L264


      
          },
          
          hsb: (n) => {
            const s = String(n).split('.'), i = s[0], f = s[1] || '', v0 = !s[1], i100 = i.slice(-2), f100 = f.slice(-2);
            return v0 && i100 == 1 || f100 == 1 ? 'one'
              : v0 && i100 == 2 || f100 == 2 ? 'two'
              : v0 && (i100 == 3 || i100 == 4) || (f100 == 3 || f100 == 4) ? 'few'
              : 'other';
          },
          
          hu: a,
          
          hy: (n) => n >= 0 && n < 2 ? 'one' : 'other',
          
          ia: d,
          
          id: e,
          
          ig: e,
          
          ii: e,

I don’t understand Hungarian at all, maybe someone could help point out whether their plural definition is wrong or ours

Topic		Replies	Views
Overridden translation sticking after being pluralized bug translation	4	287	August 2, 2024
Always use %{count} variable when translating pluralized strings translations	7	2818	May 20, 2019
Can't override pluralized string if it is missing in the locale file bug translation	6	989	May 15, 2019
Inconsistency in plural definition bug fixed	5	105	August 3, 2024
Meta bug: non-plural marked strings translations	12	2729	August 15, 2016

Issue with pluralized (count) translation override

Related Topics