I made a PR to fix the error when opening the composer:
main ← Arkshine:update-for-helper-change
opened 03:00PM - 19 Feb 25 UTC
> The helper is now available in all decoration locations, so we should gate thi… s logic on the presence of the post model instead. -- David
This PR fixes the following error when the composer is open:
3 Likes
The last time I tested it, I stumbled on an issue with it: when filling the input, it generates this error:
I was not able to figure out why, to be honest, but I took the opportunity to clean/modernize the TC and fix minor issues (and that includes using FormKit instead, which fixed the problem)
main ← Arkshine:cleanup-modernize
opened 10:00PM - 02 Mar 25 UTC
This PR fixes minor issues, modernizes, and does some cleanup.
* Uses FormKi… t in the modal [^1]
* Increases random ID length from 8 to 10 characters to avoid getting a popup saying ID is unsafe.
* Groups the iframe-related checkboxes with a title for consistency, and simplifies the locale.
* `decorateCooked` -> `decorateCookedElement`
* Removes version from `withPluginApi` (TC is already pinned to 3.5.0.beta1-dev)
* Renders the launch button with a glimmer component
* The preview renders now the button (click is disabled). Before, there was nothing.
* Fixes the username not filled when Jitsi loads. It replaces `jitsiAPI.executeCommand` by specifying the `userInfo` object.
* Adds `{ once: true }` param to `jitsiAPI.addEventListener`
* Chat: fixed direct link when spaces are used by encoding room ID.
* Updates lint configs
Locales:
* Added: `modal.iframe_title`
* Modified: `modal.desktop_iframe`, `modal.mobile_iframe`
[^1]: Before/After
3 Likes
