JS error after upgrade

(Woody Gilk) #1

After upgrading to latest discourse this morning, I see the following error in the JS console and my forum does not load:

Uncaught SyntaxError: missing ) after argument list

Here’s a screenshot of the issue, you can see it live on http://discourse.kohanaframework.org

(Felix Freiberger) #2

Are you running any non-standard plugins?
Are you behind Cloudflare?

(Woody Gilk) #3

Yes, we use CloudFlare. I’ve turned off “JS minification” and that seems to have made the problem go away.

Does Discourse not test against minified files?!

(Rafael dos Santos Silva) #4

The purpose of a minify is to NOT alter program behavior, while decreasing size.

Discourse already minifies the assets. Cloudfare have a broken minifier.

(Jeff Atwood) #5

I think you meant to say:

Does Cloudflare not test their minifier?!

When functioning code is broken by a third party, that is not the code’s fault.

(Sam Saffron) #6

Can you please raise this with cloudflare and post your issue number here?

(Woody Gilk) #7

Sam, I’ve raised the issue to CF, my issue number is #1067945

(Jeff Atwood) #8

Good news! After some public shaming on my part, this is now fixed on Cloudflare’s side for everyone, worldwide.

I’m deleting all the other topics on this as ancient history.