Last visit red line not moving on meta

sam · August 9, 2023, 2:35am

Our definition of visit is here:

discourse/discourse/blob/175f6f6a14248b7997818daf5050fe2f45118e13/app/models/user.rb#L2092-L2099


      
          def previous_visit_at_update_required?(timestamp)
            seen_before? && (last_seen_at < (timestamp - SiteSetting.previous_visit_timeout_hours.hours))
          end
          
          def update_previous_visit(timestamp)
            update_visit_record!(timestamp.to_date)
            update_column(:previous_visit_at, last_seen_at) if previous_visit_at_update_required?(timestamp)
          end

So we consider it a “previous visit” if there is more than 1 hour (SiteSetting.previous_visit_timeout_hours) elapsed since last visit.

This line will only move 1 time an hour max.

This feels a lot more like a support topic than an actual bug?

Topic		Replies	Views
Orange last visit marker dissapeared Bug	12	1342	July 13, 2020
Timeline gets stuck when going to last/first post Bug	6	861	June 23, 2017
Already seen posts appearing above Last Visit line? Bug	4	732	May 23, 2023
Last visit line strikes through text UX	6	588	June 1, 2021
Last visit doesn't work for fixed topic list Bug	2	664	February 2, 2019

Last visit red line not moving on meta

Related Topics