The launcher help text indicates that cleanup command removes containers that have stopped for > 24 hours:
https://github.com/discourse/discourse_docker/blob/026a664e77844c7b0d67a5609f08e67f1e436d5f/launcher#L15-L15
But the issued commands filter with 1 hour , and prune containers and images :
https://github.com/discourse/discourse_docker/blob/026a664e77844c7b0d67a5609f08e67f1e436d5f/launcher#L238-L239
Should the help text on line 15 be updated to describe the actual action? Or 1h → 1d perhaps.
sam
(Sam Saffron)
February 3, 2021, 1:02am
2
Sure, make a PR for that.
3 Likes
Wouldn’t it be safer if we actually changed the code so that it removes containers stopped for > 24 hours, as indicated by the text? An hour seems pretty aggressive.
3 Likes
sam
(Sam Saffron)
February 8, 2021, 1:04am
4
Fine with that as well! I will just go ahead and push it.
https://github.com/discourse/discourse_docker/pull/524
3 Likes
sam
(Sam Saffron)
Closed
February 8, 2021, 9:00pm
5
This topic was automatically closed after 19 hours. New replies are no longer allowed.