Leak of stylesheet_cache targets?

Dev
1

Continuing the discussion from PostgreSQL 13 update:

Huh, that feels a little high. Meta has 33k rows. Taking a look at this query:

select count(*), target, max(updated_at) from stylesheet_cache
group by target
order by target, max(updated_at)

It looks like we have a retention cap of 50 cached stylesheets per target, but we’re leaking target specifiers, somehow?

count target updated_at
50 discourse-adplugin_37 2021-04-23T19:08:43.292Z
50 discourse-adplugin_43 2021-04-23T19:08:52.227Z
50 discourse-adplugin_54 2021-04-23T19:09:01.121Z
50 discourse-adplugin_55 2021-04-23T19:09:10.245Z
50 discourse-adplugin_57 2021-04-23T19:08:25.265Z
6 discourse-adplugin_64 2021-01-01T11:49:49.071Z
50 discourse-adplugin_65 2020-09-21T16:23:50.647Z
50 discourse-adplugin_66 2021-04-23T19:08:34.562Z
1 discourse-adplugin_71 2020-01-15T21:07:26.560Z
50 discourse-adplugin_72 2020-04-01T23:52:51.691Z
10 discourse-adplugin_75 2020-08-18T20:17:16.954Z
50 discourse-adplugin_77 2020-09-21T18:22:22.334Z
50 discourse-adplugin_9 2021-04-23T19:09:19.228Z

Additionally, this line is clearly incorrect, but it doesn’t actually matter (we just start performing the deletes sooner than necessary):

-count = StylesheetCache.count
+count = StylesheetCache.where(target: target).count
 if count > MAX_TO_KEEP
   ... code that deletes old entries, sharded on target ...
1 Like