Letter avatars broken in 1.5b5?

bug
1

We’ve just upgraded to 1.5b5(33) and letter avatars aren’t working.

They link to:

/letter_avatar_proxy/v2/letter/l/a6a055/45.png

Our site setting is still:

/letter_avatar_proxy/v2/letter/{first_letter}/{color}/{size}.png

While I notice that avatars here on meta are being served from avatars.discourse.org

Any ideas?

2 Likes
2

Ditto for us.

Looks like there were changes that went in recently impacting this code here:

https://github.com/discourse/discourse/commit/88f1a8f0b12a4bc61e6b521d0156012b4fd9aec9

3

At least until they fix it, changing the external system avatars URL to “https://avatars.discourse.org/v2/letter/{first_letter}/{color}/{size}.png” fixed the problem for me.

4

Looks like this requires a launcher rebuild to resolve, avatars are working once again.

Presumably grabbing the latest build via rebuild either creates or grabs local copies of these images. All you’re doing above is using the versions hosted on another site.

@sam if a beta upgrade isn’t going to work correctly until a rebuild has happened, isn’t it a bit silly to prompt the user with an upgrade button in the back end?

2 Likes
5

Confirmed, you must rebuild to get the fix, I will see if I can add a big red warning on /admin/upgrade page

3 Likes
6

That’ll do it. Thanks!

7

The avatars breaks in development mode though since nginx is not running on top of the rails web server. :grin:

2 Likes
8

Yeah I noticed that, maybe we should add a route for it, mainly for dev @mpalmer

1 Like
9

Would that be a route for /letter_avatar_proxy to feed back into the internal avatar generation code? I think that’d be reasonable.

3 Likes
11

I think we sorted this out a while back, closing, flag to reopen if still an issue.

2 Likes