Links in custom badge descriptions don't work in badge directory


(Tobias Eigen) #1

Sorry for being the niggler on the newly implemented badge directory - looks really great and I very much appreciate the improvement. Thank you! :heart_eyes:

One small issue remaining is that if you create a custom badge description (as of today, there is long description and short description available to be edited - thanks!) and include linked text, it just links straight to the badge and not to the actual link destination. This problem is not exhibited for default badges like guidelines and I’m not able to replicate it here on meta.

But on my site, try clicking on the “Read the FAQ” badge and you’ll see what happens. Once there on the Read FAQ badge page, you can click again on the link and it takes you to the actual FAQ. I only have the description field filled out, not the long description field.

Just updated to latest and am at v1.5.0.beta13b +155.


(Tobias Eigen) #2

Ah - this problem only shows up on my site if I’m logged in. When visiting Global Legal Empowerment Network Community Discussions in incognito mode, I am able to click through to the FAQ on my site.

I noticed this when checking out OpenMRS Talk. @downey can you confirm this?


(Michael Downey) #3

I’m not able to reproduce this on my site regardless of my signed-in state … :confused:

I was able to click through to the destination page behind the link both from the badge directory page, and the individual badge page, both for stock badges and custom ones.


(Tobias Eigen) #4

Thanks for letting me know - that’s weird.

Not really a big deal - I can remove the link from the directory for the time being now that there’s a long description field for the badge page itself.


(Sam Saffron) #5

Also unable to reproduce on my local instance, do you have any plugins or customisations in play?


(Mittineague) #6

It looks to be a custom badge. i.e Read FAQ

Did you paste the link in yourself?

https://community.namati.org/t/faq-common-questions-about-the-network-platform/1467?u=tobiaseigen


(Sam Saffron) #7

Yes, I made a custom badge on local.


(Tobias Eigen) #8

I just did a bunch of testing - disabled all my plugins and custom styling - and continue to get the same issue.

I also just tested another site I run and it's not working there either.

Here's the badges page where the link to "Kabissa Directory" should work but does not. The link takes you to the badge page instead of to the link. https://forum.kabissa.org/badges

Here's a screenshot of the HTML I used for the description.

(yes, the main Kabissa website is down right now - working on that)


(Michael Downey) #9

OK, I can reproduce it on my site, but only for badges that have an external link (including a full hostname and protocol), vs. an internal (relative) link.


(Sam Saffron) #10

Thanks, we were being very naughty :rolling_eyes: and nesting A tags. (which is very not allowed according to the HTML/5 spec)

I fixed this per:


(Sam Saffron) #11