Links in parentheses are not hyperlinked

[strager (Scott Trager)]

Continuing the discussion from Dealing with unwanted (and probably spam) accounts from other countries?:

@strager

Since you are SSOing (is that a word?) through WP, you might want to add a Captcha to your login. It is really effective against that kind of automated bot. I’d try the new one by Google (reCAPTCHA) first as it only requires a code if it thinks you may be a bot.

I noticed when typing the comment above that links in parentheses are not hyperlinked.

[codinghorror (Jeff Atwood)]

Let’s see

http://www.example.com

And (http://www.example.com) so yep, you’re right.

[sam (Sam Saffron)]

The autolink regex is nasty, and broken in quite a few cases

[codinghorror (Jeff Atwood)]

Can you post a link to the exact line of code here and I will look at it?

[sam (Sam Saffron)]

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/dialects/autolink_dialect.js

It needs to deal with diff rules for domain part vs path part vs query string

[riking (Kane York)]

@sam

// If we improperly caught a markdown link abort
if (url.match(/\(http/)) { return; }

I think this is part of the problem.

[sam (Sam Saffron)]

@sam

spaceOrTagBoundary

is another part of the problem.

[mcwumbly (Dave McClure)]

Just ran into this… It seems relatively common behavior on our site right now for people to parenthetically include links.

[jomaxro (Joshua Rosenfeld)]

Ran into this as well today. Easy enough to surround the link with <> but annoying nonetheless.

Examples:

Doesn’t work:
(http://www.example.com)
(http://www.example.com)

Works:
(<http://www.example.com>)
(http://www.example.com)

[mcwumbly (Dave McClure)]

https://github.com/discourse/discourse/pull/4523