Look at created_at when deleting IPs if last_match_at is NULL


(cpradio) #1

Continuing the discussion from Purge Blocked IP Addresses that haven't had a match for n months:

I’ve created the following PR (but it should be looked over), as we had 190 entries in our Screened IPs that were not cleaned up because they never had a match. Some were entered into Screened IPs as recent as April 12th, 2015 (by entered, I mean, they appeared there, not necessarily manually entered) to as far back as Sept 2014.

The PR for this is at
https://github.com/discourse/discourse/pull/3529

The part I’m uncertain on is the IS NULL. I’m not 100% certain the value is null, so its an assumption (but I believe a correct one)…


(Régis Hanol) #2