This is looking great! 
Can you confirm params are working as well?
This is looking great! 
Can you confirm params are working as well?
Yes, they show up in the UI if the query takes params
I was wrong; params are not currently working. I will look into that today.
The adapter for queries is an admin adapter, so non-admin users cannot access the query store. I added endpoints that non-admins can hit to get the query JSON, but it looks like that JSON is not being converted into Query models (of course, how would they be), and so the params logic is not being run. I am assuming I need a non-admin adapter for queries?
I see an issue in screenshot #3: you may want to bring back the “save without running” button, now that there’s meaningful non-query data to be saved.
Ah, didn’t spot that you had imported the green confirm button as well.
The green confirm button saves without running, and I would think that having the “Save Changes and Run” button should do exactly that.
Are you saying that the “Save Changes and Run” behavior should change, and not run the query?
Group members can now run queries that take params!
I am not able to run the specs (with bundle exec rspec), and thus have not written any tests for the new actions I created. Can anyone point me to what I am missing? The error message is uninitialized constant DataExplorer
Try LOAD_PLUGINS=1 RAILS_ENV=test bundle exec rspec
Yep, that does it. Thanks!
Note I usually just use bin/rake autospec it does that automatically, all you need to do is save plugin.rb or something.
@sam ,
What do you think about the Include query plan? checkbox for group reports?
It seems like something that group members would not need to have access to, and should be removed. Is that a correct assumption?
Agree this is info they don’t really need
This has been removed, and the PR is ready for review.
2 specs fail, but they fail on master as well. I could look into fixing those in this PR if it would be appreciated ![]()
Absolutely welcome!! We will be reviewing it shortly, thanks for the awesome work.
Estoy intentando usar esta función y parece que los grupos que agrego al formulario no se guardan, es decir, no hay forma de guardar el formulario.
Aquí hay una captura de pantalla de la consulta que me gustaría compartir con los moderadores.
Añado un grupo de la siguiente manera:
Y cuando actualizo la página, el grupo ha desaparecido:
Editar y “guardar” la consulta antes de actualizar tampoco tiene ningún efecto. Además, intenté compartir otras consultas, incluidas algunas de las predeterminadas del sistema, pero sin éxito.
Solo una actualización: he encontrado otro sitio en el que esto funciona, por lo que parece ser específico del sitio.
De todos modos, encontré una solución alternativa si la interfaz de usuario también está rota para ti; puedes agregar un grupo a la consulta mediante la API con una solicitud POST a https://example.com/admin/plugins/explorer/queries/<query_id>.
Configura tus encabezados, usa una clave de API para un usuario administrador:
Api-UsernameApi-KeyContent-Type – application/jsonConfigura el cuerpo de tu solicitud:
query[group_ids][] – cadena separada por comas de los IDs de grupo para permitir el acceso a esta consultaLo revisaré hoy o el lunes
No es urgente,
¡Gracias @j.jaffeux!
Esto debería solucionarse con:
Gracias por el informe.
Este tema se cerró automáticamente dos días después de la última respuesta. Ya no se permiten nuevas respuestas.