Method typeClass() in site-setting.js.es6 incorrectly handles multiword setting types

dmitry_fedyuk · August 27, 2015, 5:38am

The problem line:

discourse/discourse/blob/v1.4.0.beta10/app/assets/javascripts/admin/components/site-setting.js.es6#L24



@computed("setting.preview", "buffered.value")
preview(preview, value) {
  if (preview) {
    return new Handlebars.SafeString("<div class='preview'>" + preview.replace(/\{\{value\}\}/g, value) + "</div>");
  }
},

@computed('componentType')
typeClass(componentType) {
  return componentType.replace("_", "-");
},

@computed("setting.setting")
settingName(setting) {
  return setting.replace(/\_/g, ' ');
},

@computed("setting.type")
componentType(type) {
  return CustomTypes.indexOf(type) !== -1 ? type : 'string';

Surely, it must be:

return componentType.replace(/_/g, '-');

For now, typeClass() incorrectly handles multiword setting types, for example: my_setting_type => my-setting_type because JavaScript String.replace() method replaces only the first occurence by default.

zogstrip · August 27, 2015, 8:49am

Thanks. Just pushed a fix

https://github.com/discourse/discourse/commit/95c8ec50a872fab0e37ef7da7f2678542003c504

(next time you can submit a PR if you want)

Topic		Replies	Views
Inconsistency in code for watching first post Dev	6	1032	March 31, 2017
When watched words regular expressions is true, watched words does not allow uppercase regex Bug	2	1145	January 9, 2018
Classes that do not stick in HTML watched word replacements are inconsistent UX	0	38	October 15, 2024
Add translation to language files Bug translation	3	660	July 18, 2019
Unsupported String.prototype.startsWith in lib/utilities.js.es6 could break compatibility Bug	2	860	August 3, 2016

Method typeClass() in site-setting.js.es6 incorrectly handles multiword setting types

Related topics