Middle/Right Clicking on Username of Profile Card takes you to the page you are viewing, not the profile

bug
1

When reading a topic, click on a user to open their user card, then right-click and choose open in new tab or middle click (on either red circled area), you are taken to the page you are currently viewing, not their profile

Pasted image757×242 61.3 KB

Happens on Topic list too

Pasted image783×320 92.8 KB

7 Likes
2

Hmm this is due to this commit.

https://github.com/discourse/discourse/commit/72f7c265

3

@eviltrout May I check with you what problem the original commit was trying to solve? Even after switching back to link-to, the user-card seems to close once it transitions away to another route.

I’m trying to put up a fix which uses link-to and handles the user card click event in the view that will close the user card. Is that the right direction?

Thanks!

4

I believe it dealt with open the user card for User A on the topic list, now click on User B’s username to open their User Card

1 Like
5

@cpradio Ah got it. Thanks :smile:

6

Here’s a proper fix:

https://github.com/discourse/discourse/commit/0a9e2f54ff8f97ebac800dd027715347b5f70976

5 Likes