min_age / max_age filter not working correctly

bug
1

Hey there,

in our forum ( http://discuss.gradle.org ) we’d like to filter for all topics with no replies older than a day or two. It seems that min_age:1 is not respected when configured in a query. sample query:

https://discuss.gradle.org/search?q=min_age%3A2%20status%3Anoreplies%20order%3Alatest

Am I missing something obvious here or can you acknowledge that this is a bug?

cheers,
René

2

Are these the correct search querystrings, @sam?

3

Not sure if this is a bug or just a contextual wording problem, but the query you want to use is
https://discuss.gradle.org/search?q=max_age%3A2%20status%3Anoreplies%20order%3Alatest

That seems to do what you were wanting.

Looking at the code
https://github.com/discourse/discourse/blob/4be8de21a17a088946085b162c8ab4a652e9879a/lib/search.rb#L254-L262

They seem to be doing the reverse of what they describe (depending how you look at it). min_age is saying it has to be created after X days ago, and max_age is saying it should be created prior to X days ago.

2 Likes
4

thanks for clarifying. but this is quite confusing behaviour, isn’t it?

5

Not to me, but I guess it’s

To me “min_age” means “not newer than this” and
“max_age” means “not older than this”

3 Likes
6

I am open to changing the words here, its the second time it has tripped people. Any suggestions for better terms to describe this ?

older_than and newer_than ?

7

You know, I’ve been wondering the same thing, but I haven’t really come up with anything better than older_than and newer_than either.

8

Maybe part of it is “lower” dates are older while “higher” dates are newer?

Maybe before and after?

A difference would be max and min are inclusive, but before and after are exclusive

“on or before”, and “on or after”, are a bit too wordy IMHO and not everyone would understand <= >=

2 Likes
9

before and after seem like nice clear simple words, what do you think @sam?

10

Issue with before is that it does not read right.

Slack allow for before but it is way more fancy … before:june , before:yesterday , before:2016-02-17 all work there .

I guess we can go with before but add that support … should be fairly simple to support some basics there. localizing is very tricky though.

2 Likes
11

Thanks to all of you for your support here.

I like this proposal before:yesterday or before:2d is what we’re looking for.

cheers,
René

12

Ok this is now significantly simplified per

@Rene let me know what you think

4 Likes
13

cool. Thanks again for the work on this. looks good to me.

2 Likes