Mini Profiler Resources doesn't respect subfolder

(Rafael dos Santos Silva) #1

Hey guys,

This is another subfolder police public announcement.

Somewhere between 1.4.0 stable and 1.5.0.beta.8 mini profile resource url forgot how to deal with subfolders.

I’m searching for the culprit commit (between Discourse repo and Mini Profiler repo) just adding this post here so I don’t forget (because it’s Carnival in Brazil :confetti_ball:)

(Sam Saffron) #2

Scratch that, this is actually a bug in Mini Profiler, I will get it fixed if possible.

(Nick) #3

It is actually very easy to work around in the top level server’s configuration. I had this issue and solved it by adding this line to my NGINX config:

rewrite ^/mini-profiler-resources/(.*)$ /forum/mini-profiler-resources/$1 permanent;

Here are a couple more redirects I ended up making. Perhaps it will be useful to someone:

rewrite ^/letter_avatar_proxy/(.*)$ /forum/letter_avatar_proxy/$1 permanent;
rewrite ^/login-preferences$ /forum/login-preferences permanent;
rewrite ^/sidekiq/(.*)$ /forum/sidekiq/$1 permanent;

(Rafael dos Santos Silva) #4

Yes, I knew that, but no luck finding the commit that broke it on the time interval it affected me. Maybe was a subtle change?

(Sam Saffron) #5

This caused it all to happen… :frowning:

Subfolder support with Docker
(Jeff Atwood) #6

(Sam Saffron) #7

(Sam Saffron) #8

This is apparently still broken so re-opening.

(Joshua Rosenfeld) #9

Looks like mini_profiler is not happy with subfolder installs. Unfortunately, I can’t say if this was fixed and is a regression or was never fixed. Haven’t had a subfolder install to look at in a while.

(Jeff Atwood) #10

Really you should be looking at this @sam

(Sam Saffron) #12

Fixed per:

(Sam Saffron) #13