手动关闭一个设置了未来自动关闭的主题时出现UI小问题

Luke_Cousins · 2023 年12 月 21 日 20:06

设置一个主题计时器，在 x 天后关闭主题
手动关闭主题
您可以看到一行仍然显示该主题将在 x 天后关闭
单击此处的垃圾桶图标，您将收到一条错误消息：

这显然是一个非常小的 bug，我喜欢 Discourse 以及你们所做的一切，但我觉得值得一提谢谢。

sam · 2023 年12 月 22 日 02:24

感谢您提出这个问题，我添加了 pr-welcome 标签，以便社区成员可以尝试修复。

TurtleStack · 2024 年2 月 7 日 17:29

我想对这个问题进行修复。我是新来的，pr-welcome 主题有分配流程吗？

featheredtoast · 2024 年2 月 7 日 19:10

您好，欢迎！您关于“正在处理”的评论对于分配过程来说已经足够了——准备好后请将您的 PR 发送到 GitHub，我们可以看一下

TurtleStack · 2024 年2 月 7 日 21:47

PR 已发送。谢谢！

github.com/discourse/discourse

FIX: Hide timer info on topic status toggle

main ← turtlestackdev:fix/topic_timer_visible_after_status_toggle

opened 09:46PM - 07 Feb 24 UTC

turtlestackdev

+62 -0

Fix for https://meta.discourse.org/t/minor-ui-bug-with-manually-closing-a-topic-…that-has-a-topic-timer-set-for-auto-close-in-the-future/289482 When an auto close/open timer is set and the user manually opens/closes the topic, the timer info remains displayed until the page is refreshed. The changes here fix that by adding a `@statusUpdate` property to the timer info within the topic template. The `@statusUpdate` property is read in the `topic-timer-info` component. When this value is defined, and the timer `statusType` matches the the topic status, the timer info `showTopicTimer` and `executedAt` values are set to null. The latter is modified to prevent the info from being incorrectly displayed if the user toggles the status back to open. The `@statusUpdate` property is set to the value of the topic `topic_status_update` which is undefined by default. After the topic controller `toggleClosed` function finishes, this value is updated with the return value from the API. This in turn triggers another render of the `topic-timer-info` component which now has the information it needs to hide itself. This does trigger an additional render of the timer info after the hooks are fired, but I felt it was acceptable. Three acceptance tests have been added to topic-edit-timer-test.js. - auto-close timer is hidden after manually closing the topic - auto-open timer is hidden after manually opening the topic - auto-close timer is hidden after manually closing and then re-opening the topic The topic test fixture needed a minor adjustment to enable toggling the topic status.

话题		回复	浏览量
Closing a topic manually doesn't clear the topic timer's automatic closure UX topic-timers	5	766	2018 年12 月 11 日
Topic timer text not removed when timer fires and topic is open UX topic-timers	2	664	2019 年6 月 13 日
This topic will close a few seconds after the last reply Bug	8	662	2021 年2 月 15 日
Temporary Timed Closure of topic not re-opening topic Bug	3	865	2017 年8 月 23 日
Also update topic timer UI for auto-delete replies, auto-close after last post UX topic-timers	4	1057	2025 年9 月 25 日

手动关闭一个设置了未来自动关闭的主题时出现UI小问题

相关话题