Moderators don't have access to Staff category

bokos · 2018 年 10 月 5 日午後 6:33

I noticed my moderators don’t have access to the Staff category. I just installed a fresh discourse locally to test it and it still happens.

I think it’s because my Discourse got installed in German and my Staff group is actually called Team.
So I ran this in console:

staff = Category.find_by(id: SiteSetting.staff_category_id)
staff.group_names = [Group[:staff].name]
staff.save

I hope this doesn’t break anything?

codinghorror · 2018 年 10 月 5 日午後 9:11

Hmm, no, permissions aren’t set based on the text name of the category.

bokos · 2018 年 10 月 5 日午後 9:41

I just noticed I have the same issue with the Lounge category.
I think the group_names=(names) method of the Category model should find the correct name of the group? Or change the fixtures?

david · 2018 年 10 月 5 日午後 10:14

Yes, it looks like we localise the group names here:

github.com/discourse/discourse

app/models/group.rb

cbb8f6f0f


      
          
            group.id = id
            group.save!
          end
          
          # don't allow shoddy localization to break this
          localized_name = I18n.t("groups.default_names.#{name}").downcase
          validator = UsernameValidator.new(localized_name)
          
          if !Group.where("LOWER(name) = ?", localized_name).exists? && validator.valid_format?
            group.name = localized_name
          end
          
          # the everyone group is special, it can include non-users so there is no
          # way to have the membership in a table
          case name
          when :everyone
            group.visibility_level = Group.visibility_levels[:owners]
            group.save!
            return group
          when :moderators

But then set category permissions using the unlocalised group name here:

github.com/discourse/discourse

db/fixtures/502_staff_category.rb

cbb8f6f0f


      
          unless Rails.env.test?
            staff = Category.find_by(id: SiteSetting.staff_category_id)
            if staff && !staff.group_ids.include?(Group[:staff].id)
          
              # Add permissions and a description to the Staff category.
          
              Category.transaction do
                staff.group_names = ['staff']
                unless staff.save
                  puts staff.errors.full_messages
                  raise "Failed to set permissions on the Staff category!"
                end
          
                if staff.topic_id.nil?
                  creator = PostCreator.new(Discourse.system_user,
                    raw: I18n.t('staff_category_description'),
                    title: I18n.t('category.topic_prefix', category: staff.name),
                    category: staff.name,

I think this could do with some improvement

codinghorror · 2018 年 10 月 6 日午前 5:07

Oh dear, I didn’t realize we were using the string names rather than the numeric codes. I wonder why we haven’t seen more complaints about this for Discourse instances in other languages?

zoul · 2018 年 10 月 6 日午前 6:46

I’ve seen the same (or similar?) bug running Discourse in Czech and thought it was a random glitch related just to a single user. It went away after I temporarily turned the moderator into an admin and back IIRC, so I did not bother reporting it.

ErlendMS · 2024 年 1 月 20 日午前 10:42

ここでも同じ問題が発生しているようです。

Norwegian のインストールがあり、管理者アカウントにログインしている場合、スタッフカテゴリにアクセスできません。「すべてのカテゴリ」には表示されますが、クリックすると読み込みが続きます。

テストユーザーを作成し、モデレーターにしました。すると、そのユーザーはアクセスできるようになりました。

トピック		返信	表示
Everyone group in category permissions in non-English forums Bug pr-welcome	9	166	2025 年 12 月 17 日
Why are we unable to create subcats for mods within the Staff category? Support	21	1263	2020 年 7 月 19 日
Category edit dialog: default groups sometimes not translated Bug	2	991	2020 年 6 月 27 日
I cannot locate the key: staff_category_description Support	4	658	2024 年 6 月 8 日
Cannot save category security settings when adding custom group” Support	3	58	2025 年 9 月 10 日

Moderators don't have access to Staff category

関連トピック