Native theme feature feedback, bugs, thoughts, feelings, prayers

feature
41

Those should be in a scroll box not a bulleted list.

42

I donā€™t think this is expected behaviour, but as this is new for the hosted solution Iā€™m not sure.

We have one Theme. It is set as Default but it is not enabled for User Selection.

When I view my preferences, the Themes label appears, with the one and only theme listed in the drop down box.

Whilst there isnā€™t a choice as such, it is displayed and as such kind of selectable.

43

Seriously? I donā€™t consider this a problem ā€“ one choice is not a choice :wink:

Also in the released final feature, we will have multiple themes by default, at minimum:

  • light
  • dark
1 Like
44

Just wanted you to be aware in case it wasnā€™t the desired behaviour. What it does mean is that the name given previously in our case, somewhat randomly ā€œlinksā€, needs to be changed, as it is now exposed to users and makes little sense :slight_smile:

45

Well, like I said, in the final feature there will be

  • light
  • dark

@sam is currently working on it, you can direct all questions to him ā€“ thanks!

1 Like
46

Will do Jeff, thanks :slight_smile:

47

Iā€™m having some problems with the new native themes. I added a common style for the .list-controls class and it is not being loaded. Also seeing this same problem with other theme components that are loaded by the default theme. Confirmed by inspecting the elements with dev tools in Chrome, those styles are not being loaded.

Hereā€™s my site (login required): https://1849.co/

cc: @pfaffman

1 Like
48

IIRC you can only have one theme enabled by default now and what you are describing is a component, so you would go to your default already enabled theme and down in the components area, find your new component and click add.

4 Likes
49

Also, confirm you donā€™t have broken CSS by clicking save on the CSS

2 Likes
50

Thanks, @cpradio. I figured that part out.

And the css seems fine, @sam. Enabling just one child theme works just fine, but including it as a child seems to include some, but not all of the components. We donā€™t see any any conflicts and from inspecting the CSS it seems that some stuff is just missing.

We were on the latest version, but a bunch has happened since then and Iā€™m rebuilding now. Perhaps this will just go away.

Edit: The rebuild completed and it seems that all of the expected CSS is there.

2 Likes
51

Hi @sam,

Further to Jeffā€™s reply above;

Any estimation of time for the final feature?

At the time of writing I see a ā€œLight Schemeā€ listed, and, as Iā€™ve inherited the admin access, we have another already set up, but I donā€™t know if that was simply a ā€œDark Schemeā€ which got renamed, or whether that is still something to come from your good self in this feature - if you see my point.

Not chasing as such, just after an indication of expected date for roll out assuming it hasnā€™t been already.

Thanks in advance :slight_smile:

52

Gamedev is now deployed with the latest theme code, you can take advantage of this now.

Our plans to support default ā€œlight/darkā€ user selector comes with a bunch of caveats. In particular, if you already made a bunch of ā€œdarkā€ customizations (like gamedev does) you are going to have to get your hands dirty.

For example:

Your current CSS customization for you dark scheme has stuff like:

.btn:hover {
    color: #3181d2;
}

We can not somehow magic :sunny: this hardcoded CSS to its light counterpart.

What you need to do to support white/light user selectable theme is:

  • Create a theme component with shared CSS between light / dark theme. (break down you existing big theme)
  • Create a new dark theme, select the current colors, common theme component and add the unique CSS
  • Repeat for light theme

What @codinghorror is describing is very powerful for new communities, but magic-ing it in to existing communities that have a large slew of CSS customization is not something we can do without enormous levels of magic.

7 Likes
53

Hi @sam,

Thank you for your reply, thatā€™s really useful, as I was holding off doing/changing anything until I knew where things were. Really appreciate the extra info you have provided also, I hadnā€™t been involved in the previous customisations, so having a little bit of guidance on moving forwards here is really useful.

Thanks again :slight_smile:

1 Like
54

This is a little bug I think (on a dev installation updated yesterday)

The advice tells me that thereā€™s an error on line 135, but, as you can see, the error is on line 127

3 Likes
55

To me it looks like there is an error on line 120 - the comma on the end of the line?
(perhaps this is allowed in Sass / SCSS)

2 Likes
56

It looks like an invalid CSS comment to me.
Comments in HTML are like <!-- comment -->
Comments in code are eg. like // comment or # comment or /* comment */
But AFAIK the only valid comments for CSS files are
/* comment */
Even though SASS also allows // comment
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#comments

57

Nope, SCSS supports both multiline and single line comments:
http://sass-lang.com/documentation/file.SCSS_FOR_SASS_USERS.html#comments

58

But is Customise SCSS or CSS?

59

From issue #3 in the OP and Samā€™s commitā€¦Iā€™m going with SASS:
https://github.com/discourse/discourse/commit/37d4dd4a4bddb201111e541888a1f61aa6789f89

1 Like
60

Itā€™s SASS for a while now.

1 Like