Nouvelle version bêta de l'application mobile iOS disponible pour les tests

Dev
1

Suite à Delegated authentication for Discourse Mobile app, nous avons travaillé sur une nouvelle version de l’application DiscourseHub pour iOS. Cette nouvelle version inclut plusieurs modifications internes qui résolvent certains problèmes persistants de l’application iOS. Vous pouvez essayer cette nouvelle version dès maintenant en ouvrant le lien ci-dessous sur votre appareil iOS et en installant l’application via TestFlight :

https://testflight.apple.com/join/NkdBQgmg

Notes sur la nouvelle version

Il y a deux changements majeurs dans la nouvelle version de l’application :

  1. l’application utilise Safari pour l’authentification
  2. SafariViewController a maintenant été remplacé par une vue web (webview)

Le premier changement signifie que l’authentification dans l’application est désormais plus simple et mieux intégrée à iOS. Les utilisateurs pourront désormais utiliser les mots de passe enregistrés, les sessions SSO existantes ou se connecter par e-mail lors de l’authentification d’un site dans l’application. Cependant, ce changement signifie également que les utilisateurs devront se reconnecter à tous les sites qu’ils ont déjà configurés dans leur application. Il s’agit d’une exigence unique. (Si l’utilisateur est déjà connecté dans Safari, il devra simplement autoriser l’accès API de l’application.)

Le second changement, le nouveau navigateur webview, permet une expérience utilisateur plus fluide et plus rapide dans l’application et résout plusieurs problèmes que nous avions avec SafariViewController.

Quelques autres améliorations incluses dans cette version bêta :

  • la gestion des notifications push a été renforcée : les utilisateurs verront désormais des badges de notification lorsqu’ils reçoivent une notification push tandis que l’application est au premier plan
  • les sessions provenant de l’application sont désormais correctement identifiées comme telles dans Discourse, dans la section « Appareils récemment utilisés » du profil de l’utilisateur
  • dans la vue web, nous avons introduit une nouvelle barre de navigation. Sur les iPhone, cette barre est située en bas et se cache automatiquement (comme la barre de navigation de Safari), tandis que sur les iPad, elle est statique et placée en haut de la zone visible. Le style de la barre utilisera automatiquement le schéma de couleurs du thème actif.
  • l’application vérifiera régulièrement les modifications de la version de l’API et du logo d’un site, assurant ainsi que les changements de marque et les mises à jour de l’API Discourse sont reflétés dans l’application (cela résout également un problème de disparition des logos)

Pour tester ces nouvelles fonctionnalités, vos sites Discourse doivent être sur la dernière branche « tests-passed » ou sur la dernière version bêta (v2.3.0.beta9). Tout site qui n’a pas été mis à jour récemment reviendra à l’authentification héritée et à SafariViewController dans l’application.

2

Awesome work on this @pmusaraj and @sam, major improvements! :tada:

3

One immediate thing I’ve noticed is that while the new app got straight into Meta after re-authorizing, a bunch of sites on b9+7 needed me to reauthenticate.

4

Odd display issue on xsmax.

The app “back” rendering is cutoff on left side of notch.

5

Can you paste a screenshot?

6

image
8AD312D4-0710-4F29-BB64-82CD0D4091E8.jpeg1242×621 174 KB

It’s minor, and no issue when displaying normal layout, only when previous app link is displayed

7

I think I see what you mean (but I’m not sure), the button to go back to TestFlight is halfway between the two background colors. In the app, we have added some logic to change the background color behind the status bar in the iOS app. It will follow the background of your Discourse header. For example, here is how the header would look on the Fakebook theme:

image
image.png790×390 61.3 KB

On your site you have a custom header above the Discourse header, with a different background color (blue). I will look to find a way to cover these cases as well, but it might be a tiny bit tricky, there are multiple ways to add a custom header above the Discourse header.

8

Is there another caveat for preserving credentials beyond beta 9?

9

Credentials from SafariViewController can’t be preserved. SVC runs in an isolated context, the app has no access to any of the sessions/cookies in it. So, this one-time re-authentication is necessary for all users that have no sessions in Safari. I think in your case, you had a Safari session for meta, but not for the other sites in the app.

10

Not sure if this might be fixable or not, but I just tried this and mostly works great but the login / authentication was slightly roundabout for sites w/ SSO using WP Discourse. After logging in through the WordPress site I’m taken back to the forum, but not the authentication page for the app. So I click “cancel”, go back to the app home screen, then click back to the forum and (since I’m now logged in) hit the screen where I can authorize access. Not a big issue but perhaps there’s a way to save a step here.

11

I’ll look into why this is, it should redirect back to the authorization screen. Thanks for the report.

12

Totally unrelated to my previous comment but I also just thought of an idea for a small UX enhancement:

I like the new bottom nav bar (much easier than reaching to the top on a large phone; thanks!) but notice it only appears on scroll up. This makes total sense for the main topic list view where it’s infinite scroll, but for individual topics (where there is an “end of page”) I would suggest also showing the nav bar upon scrolling to page bottom.

See the Pocket iOS app for a great example of this — also a bottom action/nav bar, hidden on scroll down; shows on scroll up or upon reaching the bottom of an article.

I think this makes a lot of sense for my typical Discourse mobile use flow as well; I’m on three forums regularly and (if multiple have updates) typically right after I finish catching up on the last new topic is when I want to close out of that forum view and switch to another.

13

We have implemented something like this, you need to scroll twice to the bottom of the page for the nav bar to show up again. It’s very similar to what Safari does upon hitting the bottom of a page.

14

Ah cool I see that now! Did not occur to me to try that, good to know :slight_smile:

15

If possible, could the icon circled in the screenshot match the icon conventionally used to launch the share sheet on iOS? It being a link is a little ambiguous until you click on it.

Current icon:

image
8FD3D28C-B25C-4E16-B25D-9B9F5872F132.jpeg1125×2436 425 KB

Conventional iOS share sheet icon:
image

16

I’ve just realised we’ve lost the old refresh button which was previously top-right.

Appreciate that it shouldn’t be necessary, but it’s definitely useful on occasion. Is there any plan to implement pull-to-refresh?

17

@justin I also find the link icon sub-optimal when it comes to sharing. I chose it because it’s the same icon we use when sharing a post in Discourse. FontAwesome doesn’t have a direct equivalent to the conventional iOS share icon, the closest icons to the conventional iOS icon are share-square and external-link-alt, both of which I’m not particularly fond of. That said, we don’t have to stick to FontAwesome, we could use iOS-style icons for all four of the bottom bar actions…

@Stephen we don’t currently have plans to add a refresh button or to support pull-to-refresh. In fact, pulling from the title bar downwards currently dismisses the webview, which is useful, sometimes.

18

The app works fine with Meta, but not with my own Discourse instance.
This is what I see in the error log:

Message

Failed to handle exception in exception app middleware : PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_user_api_keys_on_client_id"
DETAIL:  Key (client_id)=(42c39dc...) already exists.
: INSERT INTO "user_api_keys" ("user_id", "client_id", "key", "application_name", "push_url", "created_at", "updated_at", "scopes") VALUES (4, '42c39dc...', '19eaf98...', 'Discourse - iPhone', 'https://api.discourse.org/api/publish_ios', '2019-04-30 15:05:35.056396', '2019-04-30 15:05:35.056396', '{notifications,session_info,one_time_password}') RETURNING "id"
19

I have seen this error on my dev instance (in your case, it’s likely related to an old auth token that hasn’t been removed properly). Have you tried removing the site from the app (swipe right-to-left and then delete) and trying again? Alternately, in your Discourse instance, you can go to your user preferences and “Revoke Access” for the apps you have listed.

20

I’ve tried both ways unsuccessfully. Although,

I couldn’t find this exact preference. What I did find is Recently Used Devices on my account preferences, where I could log out on my iPhone.