New User of the Month badge awarded before registraton date

jughead · July 10, 2020, 2:27pm

Hello all!

I’ve just noticed that two of my users got the New user of the month badge before their actual registration date. That shouldn’t be possible should it?

I currently have two members that have been granted this badge before registration date.

simon · July 11, 2020, 1:05am

I think there’s a problem with the logic that’s being used here:

github.com

discourse/discourse/blob/master/app/jobs/scheduled/grant_new_user_of_the_month_badges.rb#L13-L25


previous_month_beginning = 1.month.ago.beginning_of_month
previous_month_end = 1.month.ago.end_of_month

return if UserBadge.where("badge_id = ? AND granted_at BETWEEN ? AND ?",
  badge.id, previous_month_beginning, Time.zone.now
).exists?

scores(previous_month_beginning).each do |user_id, score|
  # Don't bother awarding to users who haven't received any likes
  if score > 0.0
    user = User.find(user_id)
    if user.badges.where(id: Badge::NewUserOfTheMonth).blank?
      BadgeGranter.grant(badge, user, created_at: previous_month_end)

It’s checking stats for any users who were created after the beginning of the previous month. So if a user joined in mid June, it will be checking stats from the beginning of May up until mid June. The badge is then has its created_at date set to the end of the previous month (May 31). This would allow a user who was created in June to have their New User of the Month badge awarded at the end of May.

eviltrout · July 13, 2020, 7:06pm

Nice repro @simon!

This fixes it:

codinghorror · July 13, 2020, 11:54pm