New User of the Month badge awarded before registraton date

simon · July 11, 2020, 1:05am

I think there’s a problem with the logic that’s being used here:

discourse/discourse/blob/main/app/jobs/scheduled/grant_new_user_of_the_month_badges.rb#L13-L25


      
          previous_month_beginning = 1.month.ago.beginning_of_month
          previous_month_end = 1.month.ago.end_of_month
          
          if UserBadge.where(
               "badge_id = ? AND granted_at BETWEEN ? AND ?",
               badge.id,
               previous_month_beginning,
               Time.zone.now,
             ).exists?
            return
          end
          
          scores(previous_month_beginning, previous_month_end).each do |user_id, score|

It’s checking stats for any users who were created after the beginning of the previous month. So if a user joined in mid June, it will be checking stats from the beginning of May up until mid June. The badge is then has its created_at date set to the end of the previous month (May 31). This would allow a user who was created in June to have their New User of the Month badge awarded at the end of May.

Topic		Replies	Views
"New User of the Month" badge doesn't appear to be monthly? Bug	14	1248	May 28, 2017
How Do You Get The New User Of The Month Badge? Support	3	1215	October 6, 2019
New user of the month: wrong month, not localized Translations	11	2839	January 28, 2020
Two New Users of the Month? Support badges	4	287	November 23, 2022
New User Of The Month Badge Bug	7	827	August 10, 2020

New User of the Month badge awarded before registraton date

Related topics