NoMethodError after upgrade

scavin · July 5, 2024, 2:27am

After upgrading Discourse, logged-in users encountered this issue, but non-logged-in users were normal.

Oops
The software powering this discussion forum encountered an unexpected problem. We apologize for the inconvenience.

Detailed information about the error was logged, and an automatic notification generated. We'll take a look at it.

No further action is necessary. However, if the error condition persists, you can provide additional detail, including steps to reproduce the error, by posting a discussion topic in the site's feedback category.

Then, I found this error in /logs.

Message (42 copies reported)

NoMethodError (undefined method `[]' for nil)
app/controllers/application_controller.rb:631:in `preload_current_user_data'
app/controllers/application_controller.rb:448:in `preload_json'
app/controllers/application_controller.rb:424:in `block in with_resolved_locale'
app/controllers/application_controller.rb:424:in `with_resolved_locale'
lib/middleware/omniauth_bypass_middleware.rb:64:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:393:in `call'
lib/middleware/csp_script_nonce_injector.rb:12:in `call'
config/initializers/008-rack-cors.rb:26:in `call'
lib/freedom_patches/rails_rack_logger_from_rails_7_2.rb:35:in `call_app'
lib/freedom_patches/rails_rack_logger_from_rails_7_2.rb:22:in `call'
config/initializers/100-quiet_logger.rb:20:in `call'
config/initializers/100-silence_logger.rb:29:in `call'
lib/middleware/enforce_hostname.rb:24:in `call'
lib/middleware/request_tracker.rb:360:in `call'

Backtrace

plugins/discourse-ai/lib/ai_helper/assistant.rb:36:in `block (2 levels) in available_prompts'
activerecord (7.1.3.4) lib/active_record/relation/delegation.rb:100:in `each'
activerecord (7.1.3.4) lib/active_record/relation/delegation.rb:100:in `each'
plugins/discourse-ai/lib/ai_helper/assistant.rb:29:in `map'
plugins/discourse-ai/lib/ai_helper/assistant.rb:29:in `block in available_prompts'
plugins/discourse-ai/lib/multisite_hash.rb:21:in `fetch'
plugins/discourse-ai/lib/ai_helper/assistant.rb:19:in `available_prompts'
plugins/discourse-ai/lib/ai_helper/entry_point.rb:41:in `block in inject_into'
(eval at /var/www/discourse/vendor/bundle/ruby/3.3.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:467):88:in `_fast_attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:468:in `rescue in attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:455:in `attributes'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:480:in `_serializable_hash'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:359:in `serializable_hash'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:347:in `as_json'
activesupport (7.1.3.4) lib/active_support/json/encoding.rb:23:in `encode'
activesupport (7.1.3.4) lib/active_support/json/encoding.rb:23:in `encode'
activesupport (7.1.3.4) lib/active_support/core_ext/object/json.rb:42:in `to_json'
active_model_serializers (0.8.4) lib/active_model/serializer.rb:331:in `to_json'
multi_json (1.15.0) lib/multi_json/adapters/oj.rb:56:in `dump'
multi_json (1.15.0) lib/multi_json/adapters/oj.rb:56:in `dump'
multi_json (1.15.0) lib/multi_json/adapter.rb:25:in `dump'
multi_json (1.15.0) lib/multi_json.rb:139:in `dump'
app/controllers/application_controller.rb:631:in `preload_current_user_data'
app/controllers/application_controller.rb:448:in `preload_json'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:403:in `block in make_lambda'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:202:in `block (2 levels) in halting'
actionpack (7.1.3.4) lib/abstract_controller/callbacks.rb:34:in `block (2 levels) in <module:Callbacks>'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:203:in `block in halting'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:598:in `block in invoke_before'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:598:in `each'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:598:in `invoke_before'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:119:in `block in run_callbacks'
app/controllers/application_controller.rb:424:in `block in with_resolved_locale'
i18n (1.14.5) lib/i18n.rb:351:in `with_locale'
app/controllers/application_controller.rb:424:in `with_resolved_locale'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:130:in `block in run_callbacks'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:141:in `run_callbacks'
actionpack (7.1.3.4) lib/abstract_controller/callbacks.rb:258:in `process_action'
actionpack (7.1.3.4) lib/action_controller/metal/rescue.rb:25:in `process_action'
actionpack (7.1.3.4) lib/action_controller/metal/instrumentation.rb:74:in `block in process_action'
activesupport (7.1.3.4) lib/active_support/notifications.rb:206:in `block in instrument'
activesupport (7.1.3.4) lib/active_support/notifications/instrumenter.rb:58:in `instrument'
activesupport (7.1.3.4) lib/active_support/notifications.rb:206:in `instrument'
actionpack (7.1.3.4) lib/action_controller/metal/instrumentation.rb:73:in `process_action'
actionpack (7.1.3.4) lib/action_controller/metal/params_wrapper.rb:261:in `process_action'
activerecord (7.1.3.4) lib/active_record/railties/controller_runtime.rb:32:in `process_action'
actionpack (7.1.3.4) lib/abstract_controller/base.rb:160:in `process'
actionview (7.1.3.4) lib/action_view/rendering.rb:40:in `process'
rack-mini-profiler (3.3.1) lib/mini_profiler/profiling_methods.rb:89:in `block in profile_method'
actionpack (7.1.3.4) lib/action_controller/metal.rb:227:in `dispatch'
actionpack (7.1.3.4) lib/action_controller/metal.rb:309:in `dispatch'
actionpack (7.1.3.4) lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
actionpack (7.1.3.4) lib/action_dispatch/routing/route_set.rb:32:in `serve'
actionpack (7.1.3.4) lib/action_dispatch/routing/mapper.rb:21:in `block in <class:Constraints>'
actionpack (7.1.3.4) lib/action_dispatch/routing/mapper.rb:51:in `serve'
actionpack (7.1.3.4) lib/action_dispatch/journey/router.rb:51:in `block in serve'
actionpack (7.1.3.4) lib/action_dispatch/journey/router.rb:131:in `block in find_routes'
actionpack (7.1.3.4) lib/action_dispatch/journey/router.rb:124:in `each'
actionpack (7.1.3.4) lib/action_dispatch/journey/router.rb:124:in `find_routes'
actionpack (7.1.3.4) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (7.1.3.4) lib/action_dispatch/routing/route_set.rb:882:in `call'
lib/middleware/omniauth_bypass_middleware.rb:64:in `call'
rack (2.2.9) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.2.9) lib/rack/conditional_get.rb:27:in `call'
rack (2.2.9) lib/rack/head.rb:12:in `call'
actionpack (7.1.3.4) lib/action_dispatch/http/permissions_policy.rb:36:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:393:in `call'
lib/middleware/csp_script_nonce_injector.rb:12:in `call'
config/initializers/008-rack-cors.rb:26:in `call'
rack (2.2.9) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.9) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/cookies.rb:689:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
activesupport (7.1.3.4) lib/active_support/callbacks.rb:101:in `run_callbacks'
actionpack (7.1.3.4) lib/action_dispatch/middleware/callbacks.rb:28:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
logster (2.19.1) lib/logster/middleware/reporter.rb:40:in `call'
lib/freedom_patches/rails_rack_logger_from_rails_7_2.rb:35:in `call_app'
lib/freedom_patches/rails_rack_logger_from_rails_7_2.rb:22:in `call'
config/initializers/100-quiet_logger.rb:20:in `call'
config/initializers/100-silence_logger.rb:29:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/request_id.rb:28:in `call'
lib/middleware/enforce_hostname.rb:24:in `call'
rack (2.2.9) lib/rack/method_override.rb:24:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/executor.rb:14:in `call'
rack (2.2.9) lib/rack/sendfile.rb:110:in `call'
rack-mini-profiler (3.3.1) lib/mini_profiler.rb:191:in `call'
message_bus (4.3.8) lib/message_bus/rack/middleware.rb:60:in `call'
lib/middleware/request_tracker.rb:360:in `call'
actionpack (7.1.3.4) lib/action_dispatch/middleware/remote_ip.rb:92:in `call'
railties (7.1.3.4) lib/rails/engine.rb:536:in `call'
railties (7.1.3.4) lib/rails/railtie.rb:226:in `public_send'
railties (7.1.3.4) lib/rails/railtie.rb:226:in `method_missing'
rack (2.2.9) lib/rack/urlmap.rb:74:in `block in call'
rack (2.2.9) lib/rack/urlmap.rb:58:in `each'
rack (2.2.9) lib/rack/urlmap.rb:58:in `call'
unicorn (6.1.0) lib/unicorn/http_server.rb:634:in `process_client'
unicorn (6.1.0) lib/unicorn/http_server.rb:739:in `worker_loop'
unicorn (6.1.0) lib/unicorn/http_server.rb:547:in `spawn_missing_workers'
unicorn (6.1.0) lib/unicorn/http_server.rb:143:in `start'
unicorn (6.1.0) bin/unicorn:128:in `<top (required)>'
vendor/bundle/ruby/3.3.0/bin/unicorn:25:in `load'
vendor/bundle/ruby/3.3.0/bin/unicorn:25:in `<main>'

Env

Finally, I removed the discourse-ai plugin and rebuilt it, and it started working normally.

pangbo · July 5, 2024, 8:35am

Hi,

From the URL in your profile, I guess your Discourse site’s locale is set to Simplified Chinese. I encountered the same issue. The cause of the problem is that Simplified Chinese is coded as “zh_CN” in the site settings, but the key in LocaleSiteSetting is “zh”, leading to a mismatch.

I have created a PR to fix this issue:

github.com/discourse/discourse-ai

Fix: AiHelper malfunction when site's locale is Simplified Chinese

discourse:main ← ShuiyuanSJTU:fix/locale_hash

opened 08:30AM - 05 Jul 24 UTC

pangbo13

+8 -1

The latest AI plugin encounters an error when using the editor AI assistant's tr…anslation feature if the site setting or user custom language is set to Simplified Chinese (zh_CN). I noticed a similar issue being reported on meta: [NoMethodError after upgrade](https://meta.discourse.org/t/nomethoderror-after-upgrade/315073). The error originates from: https://github.com/discourse/discourse-ai/blob/d555f18c6fadd4676d70ddd44f0bf63f2a8e8228/lib/ai_helper/assistant.rb#L32 The cause of the problem is that Simplified Chinese is coded as "zh_CN" in the site settings, but the key in LocaleSiteSetting is "zh", leading to a mismatch. This PR fixes the issue by copying the approach used in Discourse core: https://github.com/discourse/discourse/blob/bb0daa33cd93eeffb230689d1daacd737f61b2e7/app/models/locale_site_setting.rb#L11

keegan · July 10, 2024, 7:06pm

We should also have a separate key for Simplified Chinese in LocaleSiteSetting. It looks like when support for Simplified Chinese language was added, the additional key was not added to names.yml.

I’ve made a PR to core to add this. This should avoid adding this workaround fix in Discourse AI.

github.com/discourse/discourse

DEV: Add missing Chinese simplified to `names.yml`

discourse:main ← discourse:dev-add-chinese-simplified

opened 07:01PM - 10 Jul 24 UTC

keegangeorge

+3 -0

Support for Chinese Simplified (`zh_CN`) was added way back [here](https://githu…b.com/discourse/discourse/commit/c5761eae8afe37e20cec0d0f9d14b85b6e585bda). However, the language code was not added to `names.yml` which results in it missing from the `LocaleSiteSetting.language_names`. This became apparent when Discourse AI added a commit which depends on `LocaleSiteSetting.language_names` for its translation features and [an issue](https://meta.discourse.org/t/nomethoderror-after-upgrade/315073/2?u=keegan) became present with Chinese simplified. **This PR adds Chinese Simplified to `zh_CN` to the `names.yml` file.**

nat · July 13, 2024, 12:00am

This topic was automatically closed after 40 hours. New replies are no longer allowed.

Topic		Replies	Views
Production.log give No method error and Discourse not working Support	9	1169	January 9, 2020
Method missing when posting a new post Support	4	421	May 15, 2020
NoMethodError in force_edit_last_validator Bug	2	867	December 5, 2018
Upgrade button is 500-ing for me Support docker	10	2659	February 14, 2015
NoMethodError downcase s3_bucket_name absolute_base_url Installation s3	4	912	December 24, 2020

NoMethodError after upgrade

Related topics