Non-staff users are able to access uncategorized even when disabled

(Joshua Rosenfeld) #1

While researching Can't prevent creation of uncategorized topics, I found that users can view #uncategorized even if it is disabled via site setting and has no topics within it. Users can visit it by navigating directly /c/uncategorized, as well as by searching in the category filter dropdown:


The New Topic button is on the (empty) page, and lets them start composing without selecting a category, which shouldn’t be possible with the setting off. The composer should look like this:

(Jeff Atwood) #2

Maybe we regressed here @joffreyjaffeux? Not sure.

(Joffrey Jaffeux) #4

I don’t think we regressed here.

(Joshua Rosenfeld) #5

Fine with me.

What about this? It seems like a regression to me - with #uncategorized disabled users should be required to select a category before composing the body. However they are able to compose the body without a category if they click new topic from the uncategorized page.

(Joffrey Jaffeux) #6

Yes I fixed what was very easy for me. Need to think about the composer, if you thought we absolutely had to remove the URL, then it was solved with it. Maybe I should just redirect. Need to dig more, uncategorized has many cases and I’m unsure what this would cause.